Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 7041009: Print Preview: Changing displayed error message when PDF Viewer is missing (again) (Closed)

Created:
9 years, 6 months ago by dpapad
Modified:
9 years, 6 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Print Preview: Changing displayed error message when PDF Viewer is missing (again) Retrying http://codereview.chromium.org/7003089/, adding new string to google_chrome_strings.grd also. BUG=See linked CR. TEST=See lined CR. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88635

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -17 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview.html View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/print_preview.js View 4 chunks +26 lines, -14 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_data_source.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dpapad
9 years, 6 months ago (2011-06-10 01:24:05 UTC) #1
Lei Zhang
LGTM
9 years, 6 months ago (2011-06-10 01:33:14 UTC) #2
commit-bot: I haz the power
9 years, 6 months ago (2011-06-10 04:04:44 UTC) #3
Change committed as 88635

Powered by Google App Engine
This is Rietveld 408576698