Issue 7041008: Moved ScopeStopObserving to a template class in change_processor.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7041008: Moved ScopeStopObserving to a template class in change_processor.h. (Closed)

Created:
9 years, 6 months ago by Andrew T Wilson (Slow)

Modified:
9 years, 6 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, GeorgeY, ncarter (slow), idana, Raghu Simha, Ilya Sherman, tim (not reviewing), dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Moved ScopeStopObserving to a template class in change_processor.h. BUG=84918 TEST=Run sync integration tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88619

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -26 lines)			Patch
M	chrome/browser/sync/glue/autofill_profile_change_processor.h	View		2 chunks	+1 line, -14 lines	0 comments	Download
M	chrome/browser/sync/glue/autofill_profile_change_processor.cc	View	1	2 chunks	+2 lines, -12 lines	0 comments	Download
M	chrome/browser/sync/glue/change_processor.h	View		1 chunk	+18 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Andrew T Wilson (Slow)

Please take a look. Also, at some point I should chat with you about whether ...

9 years, 6 months ago (2011-06-09 23:15:37 UTC) #1

Nicolas Zea

9 years, 6 months ago (2011-06-09 23:19:22 UTC) #2

LGTM. Are you planning to go through and replace the Start/Stop observing usage
for the other datatypes?