Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 7041006: Add fix suggestion for me2mom failure case. (Closed)

Created:
9 years, 6 months ago by Jamie
Modified:
9 years, 6 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Add fix suggestion for me2mom failure case. BUG=None TEST=Run remoting_simple_host --me2mom without cached credentials. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88394

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M remoting/host/simple_host_process.cc View 1 chunk +4 lines, -1 line 2 comments Download

Messages

Total messages: 5 (0 generated)
Jamie
PTAL
9 years, 6 months ago (2011-06-08 18:33:01 UTC) #1
awong
http://codereview.chromium.org/7041006/diff/1/remoting/host/simple_host_process.cc File remoting/host/simple_host_process.cc (right): http://codereview.chromium.org/7041006/diff/1/remoting/host/simple_host_process.cc#newcode92 remoting/host/simple_host_process.cc:92: access_verifier->OnMe2MomHostRegistered(successful, support_id); Why did we move this higher up?
9 years, 6 months ago (2011-06-08 18:34:45 UTC) #2
Jamie
http://codereview.chromium.org/7041006/diff/1/remoting/host/simple_host_process.cc File remoting/host/simple_host_process.cc (right): http://codereview.chromium.org/7041006/diff/1/remoting/host/simple_host_process.cc#newcode92 remoting/host/simple_host_process.cc:92: access_verifier->OnMe2MomHostRegistered(successful, support_id); On 2011/06/08 18:34:45, awong wrote: > Why ...
9 years, 6 months ago (2011-06-08 18:37:43 UTC) #3
awong
LGTM On Wed, Jun 8, 2011 at 11:37 AM, <jamiewalch@chromium.org> wrote: > > http://codereview.chromium.**org/7041006/diff/1/remoting/** > ...
9 years, 6 months ago (2011-06-08 20:10:52 UTC) #4
commit-bot: I haz the power
9 years, 6 months ago (2011-06-08 20:57:15 UTC) #5
Change committed as 88394

Powered by Google App Engine
This is Rietveld 408576698