Show composition text on IME panel when Pepper plugin is focused (Linux).

content/renderer/render_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 #include <vector>
@@ skipping 3959 matching lines @@
       char_event.text[0] = text[i];
       char_event.unmodifiedText[0] = text[i];
       if (webwidget_)
         webwidget_->handleInputEvent(char_event);
     }
   } else {
     RenderWidget::OnImeConfirmComposition(text);
   }
 }
 
-WebKit::WebTextInputType RenderView::GetTextInputType() {
+ui::TextInputType RenderView::GetTextInputType() {
   if (pepper_delegate_.IsPluginFocused()) {
     // TODO(kinaba) Until PPAPI has an interface for handling IME events, we
     // consider all the parts of PPAPI plugins are accepting text inputs.
-    return WebKit::WebTextInputTypeText;
-  } else {
-    return RenderWidget::GetTextInputType();
+    return ui::TEXT_INPUT_TYPE_TEXT;
   }
+  return RenderWidget::GetTextInputType();
+}
+
+bool RenderView::CanComposeInline() {
+  if (pepper_delegate_.IsPluginFocused()) {
+    // TODO(kinaba) Until PPAPI has an interface for handling IME events, we
+    // consider all the parts of PPAPI plugins are accepting text inputs.

[brettw, 2011/06/16 17:39:43]

I don't quite follow this comment. To me, considering all the parts of PPAPI
plugins as accepting text inputs implies that inline composition would be
available. Can you reword this?

[kochi, 2011/06/17 03:47:21]

Maybe like this:

Until PPAPI has an interface for handling IME events, there is no way for the
browser to know whether the plugin is capable of drawing composition text.  We
assume plugins are incapable and let the browser handle composition display for
now.

[kinaba, 2011/06/17 04:12:25]

Done.

+    return false;
+  }
+  return true;
 }
 
 #if defined(OS_MACOSX)
 void RenderView::PluginFocusChanged(bool focused, int plugin_id) {
   IPC::Message* msg = new ViewHostMsg_PluginFocusChanged(routing_id(),
                                                          focused, plugin_id);
   Send(msg);
 }
 
 void RenderView::StartPluginIme() {
@@ skipping 244 matching lines @@
     const webkit_glue::CustomContextMenuContext& custom_context) {
   if (custom_context.is_pepper_menu)
     pepper_delegate_.OnContextMenuClosed(custom_context);
   else
     context_menu_node_.reset();
 }
 
 void RenderView::OnNetworkStateChanged(bool online) {
   WebNetworkStateNotifier::setOnLine(online);
 }