remoting/protocol/jingle_session.cc - Issue 7040021: Fix crash condition if caller deletes PseudoTcpAdaptor from within a callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/protocol/jingle_session.cc

Issue 7040021: Fix crash condition if caller deletes PseudoTcpAdaptor from within a callback. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Change the flag we supply to Close(). Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/protocol/jingle_session.cc

diff --git a/remoting/protocol/jingle_session.cc b/remoting/protocol/jingle_session.cc

index 60fab260dc728b29666206d7c7f7262e0e6b761b..90aaf0813a72c38ea4a3b8b2e526ddc47c99f246 100644

--- a/remoting/protocol/jingle_session.cc

+++ b/remoting/protocol/jingle_session.cc

@@ -381,6 +381,8 @@ bool JingleSession::EstablishSSLConnection(

new jingle_glue::PseudoTcpAdapter(channel);

pseudotcp->Connect(&connect_callback_);

+ // TODO(wez): We shouldn't try to start SSL until the socket we're

+ // starting it on is connected.

if (cricket_session_->initiator()) {

// Create client SSL socket.

net::SSLClientSocket* socket = CreateSSLClientSocket(

« no previous file with comments | « jingle/glue/pseudotcp_adapter_unittest.cc ('k') | no next file » | no next file with comments »