Fix crash condition if caller deletes PseudoTcpAdaptor from within a callback.

jingle/glue/pseudotcp_adapter_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "jingle/glue/pseudotcp_adapter.h"
 
 #include <vector>
 
 #include "net/base/io_buffer.h"
 #include "net/base/net_errors.h"
@@ skipping 289 matching lines @@
 
   scoped_refptr<TCPChannelTester> tester =
       new TCPChannelTester(&message_loop_, host_pseudotcp_.get(),
                            client_pseudotcp_.get());
 
   tester->Start();
   message_loop_.Run();
   tester->CheckResults();
 }
 
+class DeleteOnConnected {
+ public:
+  DeleteOnConnected(MessageLoop* message_loop,
+                    scoped_ptr<PseudoTcpAdapter>* adapter)
+      : message_loop_(message_loop), adapter_(adapter) {}
+  void OnConnected(int error) {
+    adapter_->reset();
+    message_loop_->PostTask(FROM_HERE, new MessageLoop::QuitTask());
+  }
+  MessageLoop* message_loop_;
+  scoped_ptr<PseudoTcpAdapter>* adapter_;
+};
+
+TEST_F(P2PTransportImplTest, TestDeleteOnConnected) {
+  // This test verifies that deleting the adapter mid-callback doesn't lead
+  // to deleted structures being touched as the stack unrolls, so the failure
+  // mode is a crash rather than a normal test failure.
+  TestCompletionCallback client_connect_cb;
+  DeleteOnConnected host_delete(&message_loop_, &host_pseudotcp_);
+  net::CompletionCallbackImpl<DeleteOnConnected>
+      host_connect_cb(&host_delete, &DeleteOnConnected::OnConnected);
+
+  host_pseudotcp_->Connect(&host_connect_cb);
+  client_pseudotcp_->Connect(&client_connect_cb);
+  message_loop_.Run();
+
+  ASSERT_EQ(NULL, host_pseudotcp_.get());
+}
+
 }  // namespace
 
 }  // namespace jingle_glue