Fix crash condition if caller deletes PseudoTcpAdaptor from within a callback.

remoting/protocol/jingle_session.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/jingle_session.h"
 
 #include "base/message_loop.h"
 #include "crypto/rsa_private_key.h"
 #include "jingle/glue/channel_socket_adapter.h"
 #include "jingle/glue/pseudotcp_adapter.h"
@@ skipping 363 matching lines @@
     SetState(CONNECTING);
   }
 }
 
 bool JingleSession::EstablishSSLConnection(
     net::Socket* channel, scoped_ptr<SocketWrapper>* ssl_socket) {
   jingle_glue::PseudoTcpAdapter* pseudotcp =
       new jingle_glue::PseudoTcpAdapter(channel);
   pseudotcp->Connect(&connect_callback_);
 
+  // TODO(wez): We shouldn't try to start SSL until the socket we're
+  // starting it on is connected.
   if (cricket_session_->initiator()) {
     // Create client SSL socket.
     net::SSLClientSocket* socket = CreateSSLClientSocket(
         pseudotcp, server_cert_, cert_verifier_.get());
     ssl_socket->reset(new SocketWrapper(socket));
 
     int ret = socket->Connect(&ssl_connect_callback_);
     if (ret == net::ERR_IO_PENDING) {
       return true;
     } else if (ret != net::OK) {
@@ skipping 148 matching lines @@
 
     state_ = new_state;
     if (!closed_ && state_change_callback_.get())
       state_change_callback_->Run(new_state);
   }
 }
 
 }  // namespace protocol
 
 }  // namespace remoting