Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: chrome/browser/resources/print_preview.js

Issue 7040017: Print Preview: Fixing the behavior of increment/decrement buttons, destinations drop-down list. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing drop down list on hover Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview.js
diff --git a/chrome/browser/resources/print_preview.js b/chrome/browser/resources/print_preview.js
index 3b0d99a4b67eee4644268cd37f8fc1ddeda81cba..f9172533f9b143965fe210d90ac20fe8e6ecdae3 100644
--- a/chrome/browser/resources/print_preview.js
+++ b/chrome/browser/resources/print_preview.js
@@ -585,16 +585,17 @@ function pageRangesFieldChanged() {
* 'copies' value.
*/
function updateCopiesButtonsState() {
+ var copiesField = $('copies');
if (!isNumberOfCopiesValid()) {
- $('copies').classList.add('invalid');
- $('increment').disabled = true;
- $('decrement').disabled = true;
+ copiesField.classList.add('invalid');
+ $('increment').disabled = false;
+ $('decrement').disabled = false;
showInvalidHint($('copies-hint'));
}
else {
- $('copies').classList.remove('invalid');
- $('increment').disabled = false;
- $('decrement').disabled = false;
+ copiesField.classList.remove('invalid');
+ $('increment').disabled = (getCopies() == copiesField.max) ? true : false;
+ $('decrement').disabled = (getCopies() == copiesField.min) ? true : false;
hideInvalidHint($('copies-hint'));
}
}
@@ -892,9 +893,15 @@ function areArraysEqual(array1, array2) {
* Executed when the 'increment' or 'decrement' button is clicked.
*/
function onCopiesButtonsClicked(sign) {
- if($('copies').value == 1 && (sign == -1))
- return;
- $('copies').value = getCopies() + sign * 1;
+ var copiesField = $('copies');
+ if (!isNumberOfCopiesValid())
+ copiesField.value = 1;
+ else {
+ var newValue = getCopies() + sign * 1;
+ if (newValue < copiesField.min || newValue > copiesField.max)
+ return;
+ copiesField.value = newValue;
+ }
copiesFieldChanged();
}
« chrome/browser/resources/print_preview.css ('K') | « chrome/browser/resources/print_preview.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698