Print Preview: Fixing the behavior of increment/decrement buttons, destinations drop-down list.

Print Preview: Fixing the behavior of increment/decrement buttons, destinations drop-down list.

BUG=83257, 83259, 82953
TEST=See bug description.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86137

[dpapad, 2011-05-19 22:12:46]

Trying to squeeze one more bug fix in this CL.

[Lei Zhang, 2011-05-19 23:12:54]

mostly looks ok, questions/issues below:

http://codereview.chromium.org/7040017/diff/1/chrome/browser/resources/print_...
File chrome/browser/resources/print_preview.html (left):

http://codereview.chromium.org/7040017/diff/1/chrome/browser/resources/print_...
chrome/browser/resources/print_preview.html:57: max="999" class="number small"
placeholder="1"/>
what's this placeholder value?

http://codereview.chromium.org/7040017/diff/5/chrome/browser/resources/print_...
File chrome/browser/resources/print_preview.css (right):

http://codereview.chromium.org/7040017/diff/5/chrome/browser/resources/print_...
chrome/browser/resources/print_preview.css:529: background-image:
url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABMAAAAHCAYAAADqF3ZBAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAEtJREFUeNpi/P//PwO1AAuIYGRkJGgi0FJGQmqYoAobCRjUSJTTQN6E4gYQFx2DxJHU4MXoAg3kGoTNMLiBpBqEyzAGcgwCYYAAAwBwTuKv+cnjcAAAAABJRU5ErkJggg==),
I see this is the same on line 501. Is that triangle checked in somewhere? can
we do url(../path/to/triangle.png) ?

[dpapad, 2011-05-19 23:17:44]

http://codereview.chromium.org/7040017/diff/1/chrome/browser/resources/print_...
File chrome/browser/resources/print_preview.html (left):

http://codereview.chromium.org/7040017/diff/1/chrome/browser/resources/print_...
chrome/browser/resources/print_preview.html:57: max="999" class="number small"
placeholder="1"/>
On 2011/05/19 23:12:54, Lei Zhang wrote:
> what's this placeholder value?

It was there to show "1" even when the textbox was empty (since empty implies
1). Marcin did not like it, see bug description. I am fine with it, the only
weird thing now is that if you press + on an empty textfield the value goes from
empty to 2.

http://codereview.chromium.org/7040017/diff/5/chrome/browser/resources/print_...
File chrome/browser/resources/print_preview.css (right):

http://codereview.chromium.org/7040017/diff/5/chrome/browser/resources/print_...
chrome/browser/resources/print_preview.css:529: background-image:
url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABMAAAAHCAYAAADqF3ZBAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAEtJREFUeNpi/P//PwO1AAuIYGRkJGgi0FJGQmqYoAobCRjUSJTTQN6E4gYQFx2DxJHU4MXoAg3kGoTNMLiBpBqEyzAGcgwCYYAAAwBwTuKv+cnjcAAAAABJRU5ErkJggg==),
On 2011/05/19 23:12:54, Lei Zhang wrote:
> I see this is the same on line 501. Is that triangle checked in somewhere? can
> we do url(../path/to/triangle.png) ?

I had this in mind, I will give it try.

[dpapad, 2011-05-20 01:58:10]

http://codereview.chromium.org/7040017/diff/5/chrome/browser/resources/print_...
File chrome/browser/resources/print_preview.css (right):

http://codereview.chromium.org/7040017/diff/5/chrome/browser/resources/print_...
chrome/browser/resources/print_preview.css:529: background-image:
url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABMAAAAHCAYAAADqF3ZBAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAEtJREFUeNpi/P//PwO1AAuIYGRkJGgi0FJGQmqYoAobCRjUSJTTQN6E4gYQFx2DxJHU4MXoAg3kGoTNMLiBpBqEyzAGcgwCYYAAAwBwTuKv+cnjcAAAAABJRU5ErkJggg==),
On 2011/05/19 23:12:54, Lei Zhang wrote:
> I see this is the same on line 501. Is that triangle checked in somewhere? can
> we do url(../path/to/triangle.png) ?

Done.

[Lei Zhang, 2011-05-20 08:38:08]

Let's not pollute the resources directory. Put the png files in a print_preview
subdirectory, and we can move everything else over later.

[Lei Zhang, 2011-05-20 08:38:45]

Otherwise, LGTM.

[commit-bot: I haz the power, 2011-05-20 15:31:54]

Try job failure for 7040017-9001 on win:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2011-05-20 18:09:06]

Try job failure for 7040017-8005 on mac:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...