Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: src/cpu-profiler.h

Issue 7040014: Remove redundant 'running' checks for ProfilerEventsProcessor in tests. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | test/cctest/test-cpu-profiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 } 127 }
128 128
129 INLINE(static TickSampleEventRecord* init(void* value)); 129 INLINE(static TickSampleEventRecord* init(void* value));
130 }; 130 };
131 131
132 132
133 // This class implements both the profile events processor thread and 133 // This class implements both the profile events processor thread and
134 // methods called by event producers: VM and stack sampler threads. 134 // methods called by event producers: VM and stack sampler threads.
135 class ProfilerEventsProcessor : public Thread { 135 class ProfilerEventsProcessor : public Thread {
136 public: 136 public:
137 explicit ProfilerEventsProcessor(Isolate* isolate, 137 ProfilerEventsProcessor(Isolate* isolate,
138 ProfileGenerator* generator); 138 ProfileGenerator* generator);
139 virtual ~ProfilerEventsProcessor() {} 139 virtual ~ProfilerEventsProcessor() {}
140 140
141 // Thread control. 141 // Thread control.
142 virtual void Run(); 142 virtual void Run();
143 inline void Stop() { running_ = false; } 143 inline void Stop() { running_ = false; }
144 INLINE(bool running()) { return running_; } 144 INLINE(bool running()) { return running_; }
145 145
146 // Events adding methods. Called by VM threads. 146 // Events adding methods. Called by VM threads.
147 void CallbackCreateEvent(Logger::LogEventsAndTags tag, 147 void CallbackCreateEvent(Logger::LogEventsAndTags tag,
148 const char* prefix, String* name, 148 const char* prefix, String* name,
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 #endif // ENABLE_LOGGING_AND_PROFILING 293 #endif // ENABLE_LOGGING_AND_PROFILING
294 294
295 private: 295 private:
296 DISALLOW_COPY_AND_ASSIGN(CpuProfiler); 296 DISALLOW_COPY_AND_ASSIGN(CpuProfiler);
297 }; 297 };
298 298
299 } } // namespace v8::internal 299 } } // namespace v8::internal
300 300
301 301
302 #endif // V8_CPU_PROFILER_H_ 302 #endif // V8_CPU_PROFILER_H_
OLDNEW
« no previous file with comments | « no previous file | test/cctest/test-cpu-profiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698