Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 7040009: Improve HQP Title Scoring (Closed)

Created:
9 years, 7 months ago by mrossetti
Modified:
9 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Improve HQP Title Scoring I was not satisfied with how difficult it was to get reasonable scores for quite long page titles even when multiple words contained in the title were typed so I added a limit on how much of the title (and URL) string was required in order to have a decent match. BUG=None TITLE=Ran all unit tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86192

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/history/in_memory_url_index.cc View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mrossetti
This may be a second, separate review of the same change you have received. If ...
9 years, 7 months ago (2011-05-19 18:04:57 UTC) #1
Peter Kasting
OK
9 years, 7 months ago (2011-05-20 22:08:19 UTC) #2
Peter Kasting
OK
9 years, 7 months ago (2011-05-20 22:09:03 UTC) #3
mrossetti
I got two OKs but no LGTM and the commit agent barked at me. How ...
9 years, 7 months ago (2011-05-20 23:32:34 UTC) #4
Peter Kasting
9 years, 7 months ago (2011-05-21 01:07:24 UTC) #5
On 2011/05/20 23:32:34, mrossetti wrote:
> I got two OKs but no LGTM and the commit agent barked at me. How about an
LGTM?

LGTM.  Screw you commit agent!

Powered by Google App Engine
This is Rietveld 408576698