Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 7040007: Added a test case:testOmniboxSearchHistory to omnibox.py (Closed)

Created:
9 years, 7 months ago by Venkat Yellapu
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Added on test case:testOmniboxSearchHistory to omnibox.py BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86385

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M omnibox.py View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Venkat Yellapu
Added one test case:testOmniboxSearchHistory to verify that page Navigation/Search from Omnibox are added to the ...
9 years, 7 months ago (2011-05-19 18:01:04 UTC) #1
Nirnimesh
http://codereview.chromium.org/7040007/diff/1/omnibox.py File omnibox.py (right): http://codereview.chromium.org/7040007/diff/1/omnibox.py#newcode305 omnibox.py:305: """Verify Page navigation/search from omnibox are added This should ...
9 years, 7 months ago (2011-05-19 18:33:55 UTC) #2
Venkat Yellapu
Reflected the changes. Please note as we discussed yesterday, the issue 83161 is flaky and ...
9 years, 7 months ago (2011-05-20 23:25:21 UTC) #3
Nirnimesh
LGTM Please use the 'Commit:' checkbox to commit.
9 years, 7 months ago (2011-05-23 17:46:01 UTC) #4
commit-bot: I haz the power
Presubmit check for 7040007-4002 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 7 months ago (2011-05-23 18:44:32 UTC) #5
commit-bot: I haz the power
Presubmit check for 7040007-4002 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 7 months ago (2011-05-23 18:45:36 UTC) #6
Nirnimesh
Please fix these problems, and use the commit checkbox again.
9 years, 7 months ago (2011-05-23 18:50:47 UTC) #7
commit-bot: I haz the power
9 years, 7 months ago (2011-05-24 01:45:11 UTC) #8
Change committed as 86385

Powered by Google App Engine
This is Rietveld 408576698