Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Side by Side Diff: src/debug.cc

Issue 7040002: Also skip unary op IC when iterating over break locations in the debugger. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 break_point_++; 161 break_point_++;
162 return; 162 return;
163 } else if (RelocInfo::IsCodeTarget(rmode())) { 163 } else if (RelocInfo::IsCodeTarget(rmode())) {
164 // Check for breakable code target. Look in the original code as setting 164 // Check for breakable code target. Look in the original code as setting
165 // break points can cause the code targets in the running (debugged) code 165 // break points can cause the code targets in the running (debugged) code
166 // to be of a different kind than in the original code. 166 // to be of a different kind than in the original code.
167 Address target = original_rinfo()->target_address(); 167 Address target = original_rinfo()->target_address();
168 Code* code = Code::GetCodeFromTargetAddress(target); 168 Code* code = Code::GetCodeFromTargetAddress(target);
169 if ((code->is_inline_cache_stub() && 169 if ((code->is_inline_cache_stub() &&
170 !code->is_type_recording_binary_op_stub() && 170 !code->is_type_recording_binary_op_stub() &&
171 !code->is_type_recording_unary_op_stub() &&
171 !code->is_compare_ic_stub()) || 172 !code->is_compare_ic_stub()) ||
172 RelocInfo::IsConstructCall(rmode())) { 173 RelocInfo::IsConstructCall(rmode())) {
173 break_point_++; 174 break_point_++;
174 return; 175 return;
175 } 176 }
176 if (code->kind() == Code::STUB) { 177 if (code->kind() == Code::STUB) {
177 if (IsDebuggerStatement()) { 178 if (IsDebuggerStatement()) {
178 break_point_++; 179 break_point_++;
179 return; 180 return;
180 } 181 }
(...skipping 2974 matching lines...) Expand 10 before | Expand all | Expand 10 after
3155 { 3156 {
3156 Locker locker; 3157 Locker locker;
3157 Isolate::Current()->debugger()->CallMessageDispatchHandler(); 3158 Isolate::Current()->debugger()->CallMessageDispatchHandler();
3158 } 3159 }
3159 } 3160 }
3160 } 3161 }
3161 3162
3162 #endif // ENABLE_DEBUGGER_SUPPORT 3163 #endif // ENABLE_DEBUGGER_SUPPORT
3163 3164
3164 } } // namespace v8::internal 3165 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698