Add crypto_unittests to the list of tests run for heapcheck/valgrind

Add crypto_unittests to the list of tests run for heapcheck/valgrind

BUG=83183
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86218

[Ryan Sleevi, 2011-05-19 05:37:22]

PTAL.

I'm not familiar with the infrastructure enough to know if the bots themselves
depend on these changes, or if this is just used by the memory sheriffs, but
either way, crypto_unittests were missing.

[Timur Iskhodzhanov, 2011-05-19 16:44:12]

See comments at http://codereview.chromium.org/7044029/

Also, maybe add
"crypto_unittests":TestCrypto,
?

On Thu, May 19, 2011 at 9:37 AM,  <rsleevi@chromium.org> wrote:
> Reviewers: Timur Iskhodzhanov,
>
> Message:
> PTAL.
>
> I'm not familiar with the infrastructure enough to know if the bots
> themselves
> depend on these changes, or if this is just used by the memory sheriffs, but
> either way, crypto_unittests were missing.
>
> Description:
> Add crypto_unittests to the list of tests run for heapcheck/valgrind
>
> BUG=83183
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/7039057/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M tools/heapcheck/chrome_tests.py
>  M tools/valgrind/chrome_tests.py
>
>
> Index: tools/heapcheck/chrome_tests.py
> diff --git a/tools/heapcheck/chrome_tests.py
> b/tools/heapcheck/chrome_tests.py
> index
>
c3fc592c0d62eb7f8bc3e66d169d47748643d241..48a7c197f00756f6076091b73a504c6d2dd09e0b
> 100755
> --- a/tools/heapcheck/chrome_tests.py
> +++ b/tools/heapcheck/chrome_tests.py
> @@ -81,6 +81,7 @@ class ChromeTests(object):
>     self._test_list = {
>       "base": self.TestBase,            "base_unittests": self.TestBase,
>       "browser": self.TestBrowser,      "browser_tests": self.TestBrowser,
> +      "crypto_unittests": self.TestCrypto,
>       "googleurl": self.TestGURL,       "googleurl_unittests":
> self.TestGURL,
>       "courgette": self.TestCourgette,
>       "courgette_unittests": self.TestCourgette,
> @@ -254,6 +255,9 @@ class ChromeTests(object):
>   def TestBrowser(self):
>     return self.SimpleTest("chrome", "browser_tests")
>
> +  def TestCrypto(self):
> +    return self.SimpleTest("crypto", "crypto_unittests")
> +
>   def TestGURL(self):
>     return self.SimpleTest("chrome", "googleurl_unittests")
>
> Index: tools/valgrind/chrome_tests.py
> diff --git a/tools/valgrind/chrome_tests.py b/tools/valgrind/chrome_tests.py
> index
>
fb45f5556b4b6dbd05e542973bcd931a34a4c688..b640d88a7f9c282a3a64b6c658b8240c2d97fb9e
> 100755
> --- a/tools/valgrind/chrome_tests.py
> +++ b/tools/valgrind/chrome_tests.py
> @@ -216,6 +216,9 @@ class ChromeTests:
>   def TestBrowser(self):
>     return self.SimpleTest("chrome", "browser_tests")
>
> +  def TestCrypto(self):
> +    return self.SimpleTest("crypto", "crypto_unittests")
> +
>   def TestGURL(self):
>     return self.SimpleTest("chrome", "googleurl_unittests")
>
> @@ -419,6 +422,7 @@ class ChromeTests:
>     "automated_ui" : TestAutomatedUI,
>     "base": TestBase,            "base_unittests": TestBase,
>     "browser": TestBrowser,      "browser_tests": TestBrowser,
> +    "crypto_unittests": TestCrypto,
>     "googleurl": TestGURL,       "googleurl_unittests": TestGURL,
>     "courgette": TestCourgette,  "courgette_unittests": TestCourgette,
>     "ipc": TestIpc,              "ipc_tests": TestIpc,
>
>
>

[Ryan Sleevi, 2011-05-20 03:26:27]

Sorry, didn't publish the second patch set

Both ./tools/heapcheck/chrome_tests.sh and ./tools/valgrind/chrome_tests.sh run
fine with both -t crypto [as will be used by the memory buildbots] and with -t
crypto_unittests (non-abbreviated form)

[Timur Iskhodzhanov, 2011-05-21 14:22:47]

LGTM

[commit-bot: I haz the power, 2011-05-21 16:33:45]

Change committed as 86218