Fix assertion failure in range.mm while examining system dictionary popup.

chrome/browser/renderer_host/text_input_client_mac.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/renderer_host/text_input_client_mac.h"
 
 #include "base/memory/singleton.h"
 #include "base/metrics/histogram.h"
 #include "base/time.h"
 #include "chrome/common/text_input_client_messages.h"
@@ skipping 66 matching lines @@
 
   base::TimeDelta delta(base::TimeTicks::Now() - start);
   UMA_HISTOGRAM_TIMES("TextInputClient.Substring",
                       delta * base::Time::kMicrosecondsPerMillisecond);
 
   return substring_.get();
 }
 
 void TextInputClientMac::SetCharacterIndexAndSignal(NSUInteger index) {
   lock_.Acquire();
+  // |index| could be WTF::notFound (-1) and it's value is different from
+  // NSNotFound so we need to convert it.
+  if (index == static_cast<NSUInteger>(-1)) {

[Robert Sesek, 2011/05/19 15:16:56]

I think a better place to do this would be in
text_input_client_message_filter.mm. WTF::notFound is actually
static_cast<size_t>(-1) and I think it's better if this class doesn't have to
know about WTF. The message filter is also where the validation of other values
happens.

The downside with that is there's no test for that message filter. Perhaps you
could change this new test to create a TextInputClientMessageFilter and PostTask
to TextInputClientMessageFilter::OnGotCharacterIndexForPoint instead of
SetCharacterIndexAndSignal.

[bashi, 2011/05/20 04:43:15]

Moved it to text_input_client_message_filter.mm.
Since OnGotCharacterIndexForPoint() is private so I use OnMessageReceived()
instead.

+    index = NSNotFound;
+  }
   character_index_ = index;
   lock_.Release();
   condition_.Signal();
 }
 
 void TextInputClientMac::SetFirstRectAndSignal(NSRect first_rect) {
   lock_.Acquire();
   first_rect_ = first_rect;
   lock_.Release();
   condition_.Signal();
@@ skipping 16 matching lines @@
                       delta * base::Time::kMicrosecondsPerMillisecond);
 
   character_index_ = NSNotFound;
   first_rect_ = NSZeroRect;
   substring_.reset();
 }
 
 void TextInputClientMac::AfterRequest() {
   lock_.Release();
 }