Issue 7039047: Clean up bookmark_bar_folder_view testing. Specifically get it working with OCMock.

Issue 7039047: Clean up bookmark_bar_folder_view testing. Specifically get it working with OCMock. (Closed)

Created:
9 years, 7 months ago by dmac

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski, mrossetti

CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Clean up bookmark_bar_folder_view testing. Specifically get it working with OCMock. BUG=NONE TEST=BUILD Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86480

Patch Set 2 : cleaned up nits #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -179 lines)			Patch
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.h	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm	View	1	2 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm	View	1	2 chunks	+85 lines, -171 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mrossetti

LGTM http://codereview.chromium.org/7039047/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm (right): http://codereview.chromium.org/7039047/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm#newcode81 chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm:81: Nit: extra line. http://codereview.chromium.org/7039047/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm#newcode114 chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view_unittest.mm:114: Nit: Extra line.

9 years, 7 months ago (2011-05-18 20:38:30 UTC) #2

John Grabowski

http://codereview.chromium.org/7039047/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.h File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.h (right): http://codereview.chromium.org/7039047/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.h#newcode21 chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.h:21: @property(readonly, assign) BookmarkBarFolderController* controller; This may be either a ...

9 years, 7 months ago (2011-05-18 20:53:50 UTC) #3

dmac

On 2011/05/18 20:53:50, John Grabowski wrote: > http://codereview.chromium.org/7039047/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.h > File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.h (right): > > http://codereview.chromium.org/7039047/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.h#newcode21 ...

9 years, 7 months ago (2011-05-19 20:03:05 UTC) #4

John Grabowski

9 years, 7 months ago (2011-05-19 20:12:06 UTC) #5

I agree.  LGTM

On 2011/05/19 20:03:05, dmac wrote:
> On 2011/05/18 20:53:50, John Grabowski wrote:
> >
>
http://codereview.chromium.org/7039047/diff/1/chrome/browser/ui/cocoa/bookmar...
> > File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.h (right):
> > 
> >
>
http://codereview.chromium.org/7039047/diff/1/chrome/browser/ui/cocoa/bookmar...
> > chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.h:21:
> > @property(readonly, assign) BookmarkBarFolderController* controller;
> > This may be either a BookmarkBarController or a BookmarkBarFolderController.

> > Those classes do not have a parent/child relationship; one is an
> > NSWindowController, the other is an NSViewController.
> > 
> > A return value more specific than id<BookmarkButtonControllerProtocol> is
not
> > correct.
> 
> I think I fixed everything up.

Expand Messages | Collapse Messages