Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 7039045: Use /bin/bash for update_depot_tools. (Closed)

Created:
9 years, 7 months ago by cmp
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke
Visibility:
Public.

Description

Use /bin/bash for update_depot_tools. On at least one platform /usr/bin/env is actually not a guaranteed method to get to bash. Fall back to using /bin/bash for this script. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86185

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M update_depot_tools View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
cmp
9 years, 7 months ago (2011-05-18 19:46:21 UTC) #1
M-A Ruel
What about using /bin/sh ? Can you reduce the script so it's plain sh compatible?
9 years, 7 months ago (2011-05-18 19:54:16 UTC) #2
cmp
On 2011/05/18 19:54:16, Marc-Antoine Ruel wrote: > What about using /bin/sh ? > > Can ...
9 years, 7 months ago (2011-05-19 00:04:44 UTC) #3
M-A Ruel
lgtm At worst I'll get hate mail from BSDers.
9 years, 7 months ago (2011-05-19 00:31:58 UTC) #4
cmp
On 2011/05/19 00:31:58, Marc-Antoine Ruel wrote: > lgtm > > At worst I'll get hate ...
9 years, 7 months ago (2011-05-21 00:27:25 UTC) #5
cmp
9 years, 7 months ago (2011-05-23 22:59:39 UTC) #6
I needed to revert this change.  I'm abandoning it since I don't think it's
needed by my other msys changes.  (When the PATH is correct, env is available.)

Powered by Google App Engine
This is Rietveld 408576698