[cros] update screen re-factoring pt.1

chrome/browser/chromeos/login/update_screen_views_actor.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_LOGIN_UPDATE_SCREEN_VIEWS_ACTOR_H_
+#define CHROME_BROWSER_CHROMEOS_LOGIN_UPDATE_SCREEN_VIEWS_ACTOR_H_
+#pragma once
+
+#include "chrome/browser/chromeos/login/wizard_screen.h"

[whywhat, 2011/05/20 09:29:51]

Sort includes

[altimofeev, 2011/05/20 12:00:32]

Done.

+#include "chrome/browser/chromeos/login/update_view.h"
+#include "chrome/browser/chromeos/login/update_screen_actor.h"
+#include "chrome/browser/chromeos/login/view_screen.h"
+
+namespace chromeos {
+
+class UpdateScreenViewsActor : public DefaultViewScreen<chromeos::UpdateView>,
+                               public UpdateScreenActor {
+ public:
+  UpdateScreenViewsActor(WizardScreenDelegate* delegate,
+                         int width,
+                         int height);
+
+  virtual ~UpdateScreenViewsActor() {}

[whywhat, 2011/05/20 09:29:51]

I think you don't need this dtor here.

[altimofeev, 2011/05/20 12:00:32]

Why?

[whywhat, 2011/05/21 19:26:58]

Empty dtor is automatically generated and it is virtual since the dtor of the
base class is virtual.

[altimofeev, 2011/05/23 08:13:58]

I understand it. But I think that a rule of always having explicit virtual dtor
in classes with virtual methods is a good thing, even supported by our style
guide?

[whywhat, 2011/05/23 08:46:28]

OK

+
+  virtual void Show();
+  virtual void Hide();
+  virtual void ShowManualRebootInfo();
+  virtual void SetProgress(int progress);
+  virtual void ShowCurtain(bool enable);
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(UpdateScreenViewsActor);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROME_BROWSER_CHROMEOS_LOGIN_UPDATE_SCREEN_VIEWS_ACTOR_H_