Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 7039026: Adding pngs for new imageburner ui (Closed)

Created:
9 years, 7 months ago by tbarzic
Modified:
9 years, 7 months ago
Reviewers:
achuithb
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Adding pngs for new imageburner ui BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85704

Patch Set 1 #

Messages

Total messages: 6 (0 generated)
tbarzic
9 years, 7 months ago (2011-05-18 00:05:28 UTC) #1
achuithb
LGTM
9 years, 7 months ago (2011-05-18 00:11:24 UTC) #2
achuithb
Is shared/images/ the best place for this? You should also consider resources/imageburner/images/. If you think ...
9 years, 7 months ago (2011-05-18 00:20:09 UTC) #3
tbarzic
Well icon_checkmark and icon_warning could be used by someone else, the rest..not so much On ...
9 years, 7 months ago (2011-05-18 00:30:38 UTC) #4
achuithb
Ya, don't worry about it then. Might as well share them. If there are a ...
9 years, 7 months ago (2011-05-18 00:32:50 UTC) #5
tbarzic
9 years, 7 months ago (2011-05-18 00:35:13 UTC) #6
ok :)

On Tue, May 17, 2011 at 5:32 PM, <achuith@chromium.org> wrote:

> Ya, don't worry about it then. Might as well share them. If there are a lot
> of
> imageburner specific images that aren't going to get used elsewhere, it
> would
> make sense to create a separate directory.
>
>
> On 2011/05/18 00:30:38, toni wrote:
>
>> Well icon_checkmark and icon_warning could be used by someone else, the
>> rest..not so much
>>
>
>  On 2011/05/18 00:20:09, achuith.bhandarkar wrote:
>> > Is shared/images/ the best place for this? You should also consider
>> > resources/imageburner/images/. If you think there's a chance somebody
>> else
>> will
>> > want to use these icons, shared/ is definitely the right place.
>> >
>> > On 2011/05/18 00:11:24, achuith.bhandarkar wrote:
>> > > LGTM
>>
>
>
>
> http://codereview.chromium.org/7039026/
>

Powered by Google App Engine
This is Rietveld 408576698