Chromium Code Reviews| Index: base/tracked.h |
| =================================================================== |
| --- base/tracked.h (revision 85816) |
| +++ base/tracked.h (working copy) |
| @@ -41,7 +41,10 @@ |
| // Constructor should be called with a long-lived char*, such as __FILE__. |
| // It assumes the provided value will persist as a global constant, and it |
| // will not make a copy of it. |
| - Location(const char* function_name, const char* file_name, int line_number); |
| + Location(const char* function_name, |
| + const char* file_name, |
| + int line_number, |
| + const void* program_counter); |
| // Provide a default constructor for easy of debugging. |
| Location(); |
| @@ -60,9 +63,10 @@ |
| return function_name_ < other.function_name_; |
| } |
| - const char* function_name() const { return function_name_; } |
| - const char* file_name() const { return file_name_; } |
| - int line_number() const { return line_number_; } |
| + const char* function_name() const { return function_name_; } |
| + const char* file_name() const { return file_name_; } |
| + int line_number() const { return line_number_; } |
| + const void* program_counter() const { return program_counter_; } |
| void Write(bool display_filename, bool display_function_name, |
| std::string* output) const; |
| @@ -74,13 +78,19 @@ |
| const char* const function_name_; |
| const char* const file_name_; |
| const int line_number_; |
| + const void* const program_counter_; |
| }; |
| +BASE_API const void* GetProgramCounterRegister(); |
|
darin (slow to review)
2011/05/19 21:00:03
nit: maybe just call this GetProgramCounter()... R
apatrick_chromium
2011/05/19 21:09:45
Done.
|
| //------------------------------------------------------------------------------ |
| // Define a macro to record the current source location. |
| -#define FROM_HERE tracked_objects::Location(__FUNCTION__, __FILE__, __LINE__) |
| +#define FROM_HERE tracked_objects::Location( \ |
| + __FUNCTION__, \ |
| + __FILE__, \ |
| + __LINE__, \ |
| + tracked_objects::GetProgramCounterRegister()) \ |
| //------------------------------------------------------------------------------ |
| @@ -110,6 +120,11 @@ |
| base::TimeTicks tracked_birth_time() const { return base::TimeTicks::Now(); } |
| #endif // defined(TRACK_ALL_TASK_OBJECTS) |
| + // Returns null if SetBirthPlace has not been called. |
| + const void* get_birth_program_counter() const { |
| + return birth_program_counter_; |
| + } |
| + |
| private: |
| #if defined(TRACK_ALL_TASK_OBJECTS) |
| @@ -123,6 +138,8 @@ |
| #endif // defined(TRACK_ALL_TASK_OBJECTS) |
| + const void* birth_program_counter_; |
| + |
| DISALLOW_COPY_AND_ASSIGN(Tracked); |
| }; |