Issue 7039013: Add code to ia32 TypeRecordingBinaryOpStub to handle SHR Smi overflow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7039013: Add code to ia32 TypeRecordingBinaryOpStub to handle SHR Smi overflow. (Closed)

Created:
9 years, 7 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Add code to ia32 TypeRecordingBinaryOpStub to handle SHR Smi overflow. BUG=v8:1395 TEST= Committed: http://code.google.com/p/v8/source/detail?r=7937

Patch Set 1 #

Total comments: 1

Created: 9 years, 7 months ago

		Unified diffs	Side-by-side diffs	Stats (+26 lines, -14 lines)
	M	src/ia32/code-stubs-ia32.cc	View	2 chunks	+21 lines, -12 lines	1 comment
	M	src/ic.cc	View	2 chunks	+5 lines, -2 lines	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

fschneider

9 years, 7 months ago (2011-05-18 13:47:18 UTC) #2

LGTM.

http://codereview.chromium.org/7039013/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

http://codereview.chromium.org/7039013/diff/1/src/ia32/code-stubs-ia32.cc#new...
src/ia32/code-stubs-ia32.cc:1203: __ AllocateHeapNumber(eax, ecx, ebx, slow);
We should have a slow case for allocation failures, that does not enter the
patching routine.

I'd like to have that fixed as a separate change.

Expand Messages | Collapse Messages