Issue 7039004: Add enumeration to specify if smi check needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7039004: Add enumeration to specify if smi check needed (Closed)

Created:
9 years, 7 months ago by danno

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Add enumeration to specify if smi check needed R==ager@chromium.org BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=7914

Patch Set 1 #

Patch Set 2 : fix nit #

Patch Set 3 : move to common header #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -43 lines)			Patch
M	src/arm/code-stubs-arm.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View		4 chunks	+12 lines, -5 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/ic-ia32.cc	View		7 chunks	+16 lines, -7 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.h	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View		2 chunks	+4 lines, -5 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/v8globals.h	View	1 2	2 chunks	+9 lines, -1 line	0 comments	Download
M	src/x64/code-stubs-x64.cc	View		2 chunks	+8 lines, -2 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM. I wonder if there is a nice place where we can share the enum ...

9 years, 7 months ago (2011-05-17 10:29:24 UTC) #3

Søren Thygesen Gjesse

9 years, 7 months ago (2011-05-17 10:41:39 UTC) #4

On 2011/05/17 10:29:24, Mads Ager wrote:
> LGTM.
> 
> I wonder if there is a nice place where we can share the enum across platforms
> instead of repeating it.

We have a number of shared enums in v8globals.h.

Expand Messages | Collapse Messages