Issue 7038051: NTP4: Add ability to drag links to the apps pages.

Issue 7038051: NTP4: Add ability to drag links to the apps pages. (Closed)

Created:
9 years, 7 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews), Rick Byers

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

NTP4: Add ability to drag links to the apps pages. again, backend updates are not hooked up yet (because no backend exists) 1. allow tile pages to accept drags of non-tiles (with stub implementation of the tile's appearance) 2. refactor ugliness of dealing with multiple drag events into event handler thunks. This will also hopefully make it easier to hook up synthesized touch drag events. BUG=none TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86184

Patch Set 1 #

Patch Set 2 : comments #

Patch Set 3 : comments #

Total comments: 2

Patch Set 4 : this.ownerDocument #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+229 lines, -48 lines)			Patch
M	chrome/browser/resources/ntp4/apps_page.css	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/ntp4/apps_page.js	View	1 2 3	2 chunks	+72 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/ntp4/most_visited_page.js	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.css	View		2 chunks	+2 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab_theme.css	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/ntp4/tile_page.js	View	1 2	9 chunks	+136 lines, -39 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

LGTM http://codereview.chromium.org/7038051/diff/2002/chrome/browser/resources/ntp4/apps_page.js File chrome/browser/resources/ntp4/apps_page.js (right): http://codereview.chromium.org/7038051/diff/2002/chrome/browser/resources/ntp4/apps_page.js#newcode105 chrome/browser/resources/ntp4/apps_page.js:105: var title = cr.doc.createElement('span'); Use this.ownerDocument here too

9 years, 7 months ago (2011-05-20 23:49:07 UTC) #2

Evan Stade

9 years, 7 months ago (2011-05-21 00:20:05 UTC) #3

http://codereview.chromium.org/7038051/diff/2002/chrome/browser/resources/ntp...
File chrome/browser/resources/ntp4/apps_page.js (right):

http://codereview.chromium.org/7038051/diff/2002/chrome/browser/resources/ntp...
chrome/browser/resources/ntp4/apps_page.js:105: var title =
cr.doc.createElement('span');
On 2011/05/20 23:49:07, arv wrote:
> Use this.ownerDocument here too

Done.

Expand Messages | Collapse Messages