Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 7038045: Add documentation for clipboardRead and clipboardWrite permissions. (Closed)

Created:
9 years, 7 months ago by dcheng
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Add documentation for clipboardRead and clipboardWrite permissions. BUG=83438 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86334

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
M chrome/common/extensions/docs/manifest.html View 1 2 chunks +16 lines, -2 lines 1 comment Download
M chrome/common/extensions/docs/static/manifest.html View 1 2 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dcheng
9 years, 7 months ago (2011-05-20 22:11:17 UTC) #1
Erik does not do reviews
+kathyw (docs reviewer) LGTM, but perhaps a bit terse. We should link anywhere else for ...
9 years, 7 months ago (2011-05-20 22:20:18 UTC) #2
dcheng
I'm happy to take any suggestions. I'm not entirely sure where we can link to ...
9 years, 7 months ago (2011-05-20 22:22:40 UTC) #3
kathyw
Agreed that we should add a link when we can find a good document. (How ...
9 years, 7 months ago (2011-05-23 18:06:35 UTC) #4
dcheng
On 2011/05/23 18:06:35, kathyw wrote: > Agreed that we should add a link when we ...
9 years, 7 months ago (2011-05-23 19:31:01 UTC) #5
dcheng
http://codereview.chromium.org/7038045/diff/1/chrome/common/extensions/docs/manifest.html File chrome/common/extensions/docs/manifest.html (right): http://codereview.chromium.org/7038045/diff/1/chrome/common/extensions/docs/manifest.html#newcode639 chrome/common/extensions/docs/manifest.html:639: "background", "geolocation", "notifications", and "unlimitedStorage" permissions, On 2011/05/23 18:06:35, ...
9 years, 7 months ago (2011-05-23 19:31:58 UTC) #6
kathyw
9 years, 7 months ago (2011-05-23 20:29:57 UTC) #7
LGTM (with one wording nit)

http://codereview.chromium.org/7038045/diff/6001/chrome/common/extensions/doc...
File chrome/common/extensions/docs/manifest.html (right):

http://codereview.chromium.org/7038045/diff/6001/chrome/common/extensions/doc...
chrome/common/extensions/docs/manifest.html:715: <td> Indicates an app or
extension uses
an -> that the

(everywhere else we say "the")

Powered by Google App Engine
This is Rietveld 408576698