Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 7038043: [ChromeOS]More network settings UI touch ups. (Closed)

Created:
9 years, 7 months ago by xiyuan
Modified:
9 years, 7 months ago
Reviewers:
achuithb
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

[ChromeOS]More network settings UI touch ups. - Remove network section h3 specifics since options_page.css is using the latest UI now. And this makes network UI looks the same way as other parts. That is, buttons and network list are aligned instead of immediately following the section headers. - Move "-webkit-margin-start: 15px" into the div container "network-general-div" and get rid of related css rules from its children; - Remove stale css rules of "details-button", which no longer exists; BUG=none TEST=Verify ChroemOS network settings works as before. The only visual change is the button strip and network lists are now left-aligned instead of immediately following the section headers. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86150

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -34 lines) Patch
M chrome/browser/resources/options/chromeos/internet_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos/internet_options_page.css View 5 chunks +3 lines, -33 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
xiyuan
9 years, 7 months ago (2011-05-20 20:20:11 UTC) #1
achuithb
9 years, 7 months ago (2011-05-20 21:27:05 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698