win: Let CalculateIdleState() deal better with GetTickCount() wrapping around.

win: Let CalculateIdleState() deal better with GetTickCount() wrapping around.

BUG=83237
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86226

[Nico, 2011-05-20 20:00:22]

This could be shorter, but then it's harder to understand.

[Evan Martin, 2011-05-20 21:25:45]

http://codereview.chromium.org/7038042/diff/1/chrome/browser/idle_win.cc
File chrome/browser/idle_win.cc (right):

http://codereview.chromium.org/7038042/diff/1/chrome/browser/idle_win.cc#newc...
chrome/browser/idle_win.cc:25: const DWORD MAX_DWORD = static_cast<DWORD>(-1);
kMaxDWORD ?

[Nico, 2011-05-20 21:31:34]

http://codereview.chromium.org/7038042/diff/1/chrome/browser/idle_win.cc
File chrome/browser/idle_win.cc (right):

http://codereview.chromium.org/7038042/diff/1/chrome/browser/idle_win.cc#newc...
chrome/browser/idle_win.cc:25: const DWORD MAX_DWORD = static_cast<DWORD>(-1);
On 2011/05/20 21:25:46, Evan Martin wrote:
> kMaxDWORD ?

Done.

[brettw, 2011-05-21 20:25:53]

http://codereview.chromium.org/7038042/diff/3001/chrome/browser/idle_win.cc
File chrome/browser/idle_win.cc (right):

http://codereview.chromium.org/7038042/diff/3001/chrome/browser/idle_win.cc#n...
chrome/browser/idle_win.cc:29: current_idle_time = time_after_wrap +
time_after_wrap;
I think you mean time_before_wrap + time_after_wrap

[Nico, 2011-05-21 21:17:58]

http://codereview.chromium.org/7038042/diff/3001/chrome/browser/idle_win.cc
File chrome/browser/idle_win.cc (right):

http://codereview.chromium.org/7038042/diff/3001/chrome/browser/idle_win.cc#n...
chrome/browser/idle_win.cc:29: current_idle_time = time_after_wrap +
time_after_wrap;
On 2011/05/21 20:25:53, brettw wrote:
> I think you mean time_before_wrap + time_after_wrap

!! Done.

[brettw, 2011-05-21 21:42:16]

LGTM