chrome/browser/ui/webui/print_preview_handler.cc - Issue 7038041: Print Preview: Check the result from GetPrintPreviewData() and return on failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/print_preview_handler.cc

Issue 7038041: Print Preview: Check the result from GetPrintPreviewData() and return on failure. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/print_preview_handler.cc

===================================================================

--- chrome/browser/ui/webui/print_preview_handler.cc (revision 86128)

+++ chrome/browser/ui/webui/print_preview_handler.cc (working copy)

@@ -448,8 +448,10 @@

PrintPreviewUIHTMLSource::PrintPreviewData data;

PrintPreviewUI* print_preview_ui = static_cast<PrintPreviewUI*>(web_ui_);

print_preview_ui->html_source()->GetPrintPreviewData(&data);

- DCHECK(data.first);

- DCHECK_GT(data.second, 0U);

+ if (!data.first || !data.second) {

+ NOTREACHED();

+ return;

+ }

printing::PreviewMetafile* metafile = new printing::PreviewMetafile;

metafile->InitFromData(data.first->memory(), data.second);

« no previous file with comments | « no previous file | no next file » | no next file with comments »