Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issue 7038038: CrOS - Add certificate support to VPN UI. (Closed)

Created:
9 years, 7 months ago by James Cook
Modified:
9 years, 7 months ago
Reviewers:
Charlie Lee
CC:
chromium-reviews, davemoore+watch_chromium.org, kmixter1
Visibility:
Public.

Description

CrOS - Add certificate support to VPN UI. Adds support for user certificates, sending their PKCS#11 certificate ID down to flimflam. Note this does not send the certificate slot - flimflam will have to look in the TPM slot. This is similar to what we do for 802.1X Wi-Fi connection certificates. BUG=chromium-os:14111 TEST=Start with no certificates installed. Go to network menu > Private networks > Add private network. Select "L2TPIPSec + User cert". Verify connect button does not enable (because you have no certs available). Cancel, then install a user cert with certificate manager. Verify the cert appears in the Add private network dialog. Verify connect button is enabled. Verify you can connect to a VPN that requires certs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86323

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -64 lines) Patch
M chrome/browser/chromeos/cros/mock_network_library.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.h View 4 chunks +22 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.cc View 12 chunks +46 lines, -28 lines 1 comment Download
M chrome/browser/chromeos/options/vpn_config_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.cc View 8 chunks +35 lines, -20 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
James Cook
Steven, please have a look. Ken told me to just send the certificate ID, not ...
9 years, 7 months ago (2011-05-20 16:41:24 UTC) #1
James Cook
Charlie, Steven's out today and Monday - can you take a look?
9 years, 7 months ago (2011-05-20 18:42:06 UTC) #2
Charlie Lee
9 years, 7 months ago (2011-05-20 21:44:46 UTC) #3
LGTM with nits

http://codereview.chromium.org/7038038/diff/1/chrome/browser/chromeos/cros/ne...
File chrome/browser/chromeos/cros/network_library.cc (left):

http://codereview.chromium.org/7038038/diff/1/chrome/browser/chromeos/cros/ne...
chrome/browser/chromeos/cros/network_library.cc:476:
PROPERTY_INDEX_L2TPIPSEC_CERT,
is this still needed?

http://codereview.chromium.org/7038038/diff/1/chrome/browser/chromeos/options...
File chrome/browser/chromeos/options/vpn_config_view.cc (right):

http://codereview.chromium.org/7038038/diff/1/chrome/browser/chromeos/options...
chrome/browser/chromeos/options/vpn_config_view.cc:117: return
x509_certificate_model::GetPkcs11Id(cert_handle);
easier to just inline cert->os_cert_handle()

Powered by Google App Engine
This is Rietveld 408576698