Fix PP_FileOpenFlags_Dev handling:

ppapi/tests/test_file_io.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PAPPI_TESTS_TEST_FILE_IO_H_
 #define PAPPI_TESTS_TEST_FILE_IO_H_
 
 #include <string>
 
 #include "ppapi/tests/test_case.h"
 
+namespace pp {
+class FileSystem_Dev;
+}  // namespace pp
+
 class TestFileIO : public TestCase {
  public:
   explicit TestFileIO(TestingInstance* instance) : TestCase(instance) {}
 
   // TestCase implementation.
   virtual bool Init();
   virtual void RunTest();
 
  private:
+  enum OpenExpectation {
+    CREATE_IF_NOT_EXIST = 1 << 0,
+    NOT_CREATE_IF_NOT_EXIST = 1 << 1,

[darin (slow to review), 2011/05/23 18:17:42]

nit: this reads funny with the two NOTs... also, the use of NOT instead of
DONT/DOESNT hurts readability.... maybe this helps?

 CREATE_IF_DOESNT_EXIST
 DONT_CREATE_IF_DOESNT_EXIST
 ...

[yzshen1, 2011/05/23 19:48:06]

Done. Thanks! It looks much better this way. :)

On 2011/05/23 18:17:42, darin wrote:

+    OPEN_IF_EXIST = 1 << 2,
+    NOT_OPEN_IF_EXIST = 1 << 3,
+    TRUNCATE_IF_EXIST = 1 << 4,
+    NOT_TRUNCATE_IF_EXIST = 1 << 5,
+    END_OF_PAIR = NOT_TRUNCATE_IF_EXIST,

[darin (slow to review), 2011/05/23 18:17:42]

nit: i'm having trouble making sense of END_OF_PAIR.... END_OF_OPEN_EXPECTATIONS
might be better.

[yzshen1, 2011/05/23 19:48:06]

INVALID_FLAG_COMBINATION is also one kind of open expectation, so changing
END_OF_PAIR to END_OF_OPEN_EXPECTATIONS might be confusing, too.

Since I would like to emphasize that "all values above are defined in pairs:
<some_expectation> and DONT_<some_expectation>", I changed it to
END_OF_OPEN_EXPECTATION_PAIRS. I have also added comments for it.

Thanks!

On 2011/05/23 18:17:42, darin wrote:

+
+    INVALID_FLAG_COMBINATION = 1 << 6,
+  };
+
   std::string TestOpen();
   std::string TestReadWriteSetLength();
   std::string TestTouchQuery();
   std::string TestAbortCalls();
+
+  // Helper method used by TestOpen().
+  // |expectations| is a combination of OpenExpectation values. The followings
+  // are considered as valid input:
+  // 1) INVALID_FLAG_COMBINATION
+  // 2) (NOT_)?CREATE_IF_NOT_EXIST | (NOT_)?OPEN_IF_EXIST |
+  //    (NOT_)?TRUNCATE_IF_EXIST
+  std::string MatchOpenExpectations(pp::FileSystem_Dev* file_system,
+                                    size_t open_flags,
+                                    size_t expectations);
 };
 
 #endif  // PAPPI_TESTS_TEST_FILE_IO_H_