Move sorting logic from table to list.

chrome/browser/resources/shared/js/cr/ui/table.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview This implements a table control.
  */
 
 cr.define('cr.ui', function() {
-  const TableSelectionModel = cr.ui.table.TableSelectionModel;
+  const ListSelectionModel = cr.ui.ListSelectionModel;
   const ListSelectionController = cr.ui.ListSelectionController;
   const ArrayDataModel = cr.ui.ArrayDataModel;
   const TableColumnModel = cr.ui.table.TableColumnModel;
   const TableList = cr.ui.table.TableList;
   const TableHeader = cr.ui.table.TableHeader;
 
   /**
    * Creates a new table element.
    * @param {Object=} opt_propertyBag Optional properties.
    * @constructor
    * @extends {HTMLDivElement}
    */
   var Table = cr.ui.define('div');
 
   Table.prototype = {
     __proto__: HTMLDivElement.prototype,
 
     columnModel_: new TableColumnModel([]),
 
     /**
      * The table data model.
      *
-     * @type {cr.ui.table.TableDataModel}
+     * @type {cr.ui.ArrayDataModel}
      */
     get dataModel() {
       return this.list_.dataModel;
     },
     set dataModel(dataModel) {
       if (this.list_.dataModel != dataModel) {
-        this.list_.dataModel = dataModel;
         if (this.list_.dataModel) {
-          this.list_.dataModel.removeEventListener('splice', this.boundRedraw_);
           this.list_.dataModel.removeEventListener('sorted',
                                                    this.boundHandleSorted_);
         }
         this.list_.dataModel = dataModel;
-        this.list_.dataModel.table = this;
-
-
         if (this.list_.dataModel) {
-          this.list_.dataModel.addEventListener('splice', this.boundRedraw_);
           this.list_.dataModel.addEventListener('sorted',
                                                 this.boundHandleSorted_);
         }
         this.header_.redraw();
       }
     },
 
     /**
      * The table column model.
      *
      * @type {cr.ui.table.TableColumnModel}
      */
     get columnModel() {
       return this.columnModel_;
     },
     set columnModel(columnModel) {
       if (this.columnModel_ != columnModel) {
-        if (this.columnModel_) {
-          this.columnModel_.removeEventListener('change', this.boundRedraw_);
+        if (this.columnModel_)
           this.columnModel_.removeEventListener('resize', this.boundResize_);
-        }
         this.columnModel_ = columnModel;
 
-        if (this.columnModel_) {
-          this.columnModel_.addEventListener('change', this.boundRedraw_);
+        if (this.columnModel_)
           this.columnModel_.addEventListener('resize', this.boundResize_);
-        }
-        this.redraw();
+        this.invalidateAndRedraw();
       }
     },
 
     /**
      * The table selection model.
      *
      * @type
-     * {cr.ui.table.TableSelectionModel|cr.ui.table.TableSingleSelectionModel}
+     * {cr.ui.ListSelectionModel|cr.ui.table.ListSingleSelectionModel}
      */
     get selectionModel() {
       return this.list_.selectionModel;
     },
     set selectionModel(selectionModel) {
       if (this.list_.selectionModel != selectionModel) {
         if (this.dataModel)
           selectionModel.adjust(0, 0, this.dataModel.length);
         this.list_.selectionModel = selectionModel;
-        this.redraw();
+        this.invalidateAndRedraw();
       }
     },
 
     /**
      * Sets width of the column at the given index.
      *
      * @param {number} index The index of the column.
      * @param {number} Column width.
      */
     setColumnWidth: function(index, width) {
       this.columnWidths_[index] = width;
     },
 
     /**
      * Initializes the element.
      */
     decorate: function() {
       this.list_ = this.ownerDocument.createElement('list');
       TableList.decorate(this.list_);
-      this.list_.selectionModel = new TableSelectionModel(this);
+      this.list_.selectionModel = new ListSelectionModel(this);
       this.list_.table = this;
 
       this.header_ = this.ownerDocument.createElement('div');
       TableHeader.decorate(this.header_);
       this.header_.table = this;
 
       this.classList.add('table');
       this.appendChild(this.header_);
       this.appendChild(this.list_);
       this.ownerDocument.defaultView.addEventListener(
           'resize', this.header_.updateWidth.bind(this.header_));
 
-      this.boundRedraw_ = this.redraw.bind(this);
       this.boundResize_ = this.resize.bind(this);
       this.boundHandleSorted_ = this.handleSorted_.bind(this);
 
       // Make table focusable
       if (!this.hasAttribute('tabindex'))
         this.tabIndex = 0;
       this.addEventListener('focus', this.handleElementFocus_, true);
       this.addEventListener('blur', this.handleElementBlur_, true);
     },
 
@@ skipping 21 matching lines @@
      * @return {ListItem} The found list item or null if not found.
      */
     getListItemByIndex: function(index) {
       return this.list_.getListItemByIndex(index);
     },
 
     /**
      * Redraws the table.
      * This forces the list to remove all cached items.
      */
-    redraw: function() {
+    invalidateAndRedraw: function() {
       this.list_.startBatchUpdates();
       if (this.list_.dataModel) {
         for (var i = 0; i < this.list_.dataModel.length; i++) {

[rginda, 2011/05/18 23:45:19]

Apparently in chrome js code we're only supposed to omit the braces on one-line
if statements.

           this.list_.redrawItem(i);
         }
       }
       this.list_.endBatchUpdates();
       this.list_.redraw();
       this.header_.redraw();
     },
 
     /**
      * This handles data model 'sorted' event.
-     * After sorting we need to
-     *  - adjust selection
-     *  - redraw all the items
-     *  - scroll the list to show selection.
+     * After sorting we need to redraw header
      * @param {Event} e The 'sorted' event.
      */
     handleSorted_: function(e) {
-      var sm = this.list_.selectionModel;
-      sm.adjustToReordering(e.sortPermutation);
-
-      this.redraw();
-      if (sm.leadIndex != -1)
-        this.list_.scrollIndexIntoView(sm.leadIndex)
+      this.header_.redraw();
     },
 
     /**
      * Sort data by the given column.
      * @param {number} index The index of the column to sort by.
      */
     sort: function(i) {
       var cm = this.columnModel_;
       var sortStatus = this.list_.dataModel.sortStatus;
       if (sortStatus.field == cm.getId(i)) {
@@ skipping 48 matching lines @@
    * because table contents can contain controls that can be focused, and for
    * some purposes (e.g., styling), the table can still be conceptually focused
    * at that point even though it doesn't actually have the page focus.
    */
   cr.defineProperty(Table, 'hasElementFocus', cr.PropertyKind.BOOL_ATTR);
 
   return {
     Table: Table
   };
 });