webkit/glue/form_field.h - Issue 7038003: Refactor autofill form fields.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webkit/glue/form_field.h

Issue 7038003: Refactor autofill form fields. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef WEBKIT_GLUE_FORM_FIELD_H_	5 #ifndef WEBKIT_GLUE_FORM_FIELD_H_

6 #define WEBKIT_GLUE_FORM_FIELD_H_	6 #define WEBKIT_GLUE_FORM_FIELD_H_

7	7

8 #include <vector>	8 #include <vector>

9	9

10 #include "base/string16.h"	10 #include "base/string16.h"

(...skipping 24 matching lines...) Expand all Loading...
35 // TODO(dhollowa): This will be removed when we implement field ids.	35 // TODO(dhollowa): This will be removed when we implement field ids.

36 bool StrictlyEqualsHack(const FormField& field) const;	36 bool StrictlyEqualsHack(const FormField& field) const;

37	37

38 string16 label;	38 string16 label;

39 string16 name;	39 string16 name;

40 string16 value;	40 string16 value;

41 string16 form_control_type;	41 string16 form_control_type;

42 int max_length;	42 int max_length;

43 bool is_autofilled;	43 bool is_autofilled;

44 std::vector<string16> option_strings;	44 std::vector<string16> option_strings;

	45 bool is_text_input;
	dhollowa 2011/05/17 16:47:20 This is a derived field, we shouldn't be storing t This is a derived field, we shouldn't be storing this value. It can be derived from \|form_control_type\|.
45 };	46 };

46	47

47 // So we can compare FormFields with EXPECT_EQ().	48 // So we can compare FormFields with EXPECT_EQ().

48 std::ostream& operator<<(std::ostream& os, const FormField& field);	49 std::ostream& operator<<(std::ostream& os, const FormField& field);

49	50

50 } // namespace webkit_glue	51 } // namespace webkit_glue

51	52

52 #endif // WEBKIT_GLUE_FORM_FIELD_H_	53 #endif // WEBKIT_GLUE_FORM_FIELD_H_

OLD	NEW

« no previous file with comments | « chrome/renderer/autofill/form_manager.cc ('k') | webkit/glue/form_field.cc » ('j') | webkit/glue/form_field.cc » ('J')