Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 7037025: Fix handling of -0 in the unary-op IC and avoid repeated patching/transitions. (Closed)

Created:
9 years, 7 months ago by fschneider
Modified:
9 years, 6 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Fix handling of -0 in the unary-op IC and avoid repeated patching/transitions. When the stub return a heap number we do a state transition to a version HEAP_NUMBER that can handle -0. There is room for further improvement in the typefeedback for the case of -0. This change however does not address this and only fixes the acute issue. Committed: http://code.google.com/p/v8/source/detail?r=7944

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -15 lines) Patch
M src/arm/code-stubs-arm.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +11 lines, -6 lines 0 comments Download
M src/ic.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ic.cc View 2 chunks +18 lines, -4 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
fschneider
9 years, 7 months ago (2011-05-18 15:24:13 UTC) #1
William Hesse
LGTM.
9 years, 7 months ago (2011-05-18 16:12:03 UTC) #2
William Hesse
9 years, 7 months ago (2011-05-18 16:21:30 UTC) #3
Looks better to me now that it compiles.

On 2011/05/18 16:12:03, William Hesse wrote:
> LGTM.

Powered by Google App Engine
This is Rietveld 408576698