Issue 7037016: Remove os_nix from gyp variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7037016: Remove os_nix from gyp variables. (Closed)

Created:
9 years, 7 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove os_nix from gyp variables. This is extra complexity we don't need. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85776

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -13 lines)			Patch
	M	build/common.gypi	View		3 chunks	+10 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

Mark, I think you reviewed the change that added this.

9 years, 7 months ago (2011-05-17 22:20:01 UTC) #1

Mark Mentovai

9 years, 7 months ago (2011-05-17 22:25:10 UTC) #2

LGTM. I did review this. I fought against os_nix but eventually gave up when it
wound up being something that was only usable internally, and not something that
would leak beyond this file. Thanks for cleaning it up.

Expand Messages | Collapse Messages