Issue 7037007: Fix push of untagged value in type-recording unary op stub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7037007: Fix push of untagged value in type-recording unary op stub. (Closed)

Created:
9 years, 7 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix push of untagged value in type-recording unary op stub. Committed: http://code.google.com/p/v8/source/detail?r=7919

Patch Set 2 : Added comment. #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	src/ia32/code-stubs-ia32.cc	View	1	1 chunk	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

lgtm Do we need to push this to the branches? http://codereview.chromium.org/7037007/diff/1/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/7037007/diff/1/src/ia32/code-stubs-ia32.cc#newcode762 ...

9 years, 7 months ago (2011-05-18 07:06:02 UTC) #3

Lasse Reichstein

9 years, 7 months ago (2011-05-18 07:31:53 UTC) #4

No branches, just trunk.

http://codereview.chromium.org/7037007/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

http://codereview.chromium.org/7037007/diff/1/src/ia32/code-stubs-ia32.cc#new...
src/ia32/code-stubs-ia32.cc:762: IntegerConvert(masm, edx,
CpuFeatures::IsSupported(SSE3), slow);
Done.

Expand Messages | Collapse Messages

Issue 7037007: Fix push of untagged value in type-recording unary op stub. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Added comment. #

Messages