Write installer results in all relevant registry keys so that we're sure that Google Update will ...

chrome/installer/util/install_util.h

Index: chrome/installer/util/install_util.h
===================================================================
--- chrome/installer/util/install_util.h	(revision 85625)
+++ chrome/installer/util/install_util.h	(working copy)
@@ -48,15 +48,16 @@
   // This function checks if the current OS is supported for Chromium.
   static bool IsOSSupported();
 
-  // This function sets installer error information in registry so that Google
-  // Update can read it and display to the user.  |state_key| should be
-  // obtained via the state_key method of an InstallerState instance created
-  // before the machine state is modified by the installer.
-  static void WriteInstallerResult(bool system_install,
-                                   const std::wstring& state_key,
-                                   installer::InstallStatus status,
-                                   int string_resource_id,
-                                   const std::wstring* const launch_cmd);
+  // Adds work items to |install_list| to set installer error information in the
+  // registry for consumption by Google Update.  |state_key| must be the full
+  // path to an app's ClientState key.  See InstallerState::WriteInstallerResult
+  // for more details.

[robertshield, 2011/05/18 12:28:40]

I wonder if we should enforce that install_list is a NoRollbackWorkItemList
here..

[grt (UTC plus 2), 2011/05/18 13:39:30]

I've added a comment recommending this.  (We have no mechanism to enforce it
short of RTTI.)

+  static void AddInstallerResultItems(bool system_install,
+                                      const std::wstring& state_key,
+                                      installer::InstallStatus status,
+                                      int string_resource_id,
+                                      const std::wstring* const launch_cmd,
+                                      WorkItemList* install_list);
 
   // Update the installer stage reported by Google Update.  |state_key_path|
   // should be obtained via the state_key method of an InstallerState instance