Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4623)

Unified Diff: chrome/browser/ui/panels/panel_browser_frame_view.cc

Issue 7036014: Consolidate ShouldUseNativeFrame/AlwaysUseNativeFrame/UseNativeFrame spaghetti. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_browser_frame_view.cc
===================================================================
--- chrome/browser/ui/panels/panel_browser_frame_view.cc (revision 85647)
+++ chrome/browser/ui/panels/panel_browser_frame_view.cc (working copy)
@@ -141,6 +141,7 @@
title_icon_(NULL),
title_label_(NULL) {
EnsureResourcesInitialized();
+ frame_->set_frame_type(views::Window::FRAME_TYPE_FORCE_CUSTOM);
options_button_ = new views::MenuButton(NULL, std::wstring(), this, false);
options_button_->SetIcon(*(options_button_resources.normal_image));
@@ -201,10 +202,6 @@
return client_view_bounds_;
}
-bool PanelBrowserFrameView::AlwaysUseCustomFrame() const {
- return true;
-}
-
gfx::Rect PanelBrowserFrameView::GetWindowBoundsForClientBounds(
const gfx::Rect& client_bounds) const {
int top_height = NonClientTopBorderHeight();
@@ -215,10 +212,6 @@
client_bounds.height() + top_height + border_thickness);
}
-bool PanelBrowserFrameView::AlwaysUseNativeFrame() const {
- return frame_->AlwaysUseNativeFrame();
-}
-
int PanelBrowserFrameView::NonClientHitTest(const gfx::Point& point) {
if (!bounds().Contains(point))
return HTNOWHERE;
« no previous file with comments | « chrome/browser/ui/panels/panel_browser_frame_view.h ('k') | chrome/browser/ui/views/constrained_window_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698