Remove more URLRequest::RegisterProtocolFactory calls.

Remove more URLRequest::RegisterProtocolFactory calls.

Move BlobProtocolHandler and FileSystemProtocolHandler into webkit directories.
Switch test_shell to use them.

Create a ChromeBlobProtocolHandler for chrome specific tweaks.

BUG=81979
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85778

[willchan no longer on Chromium, 2011-05-17 10:22:00]

These are basically simple moves / refactors, nothing tricky's going on here.

tony for test_shell
kinuko for blob/fileapi

[tony, 2011-05-17 17:01:00]

http://codereview.chromium.org/7036004/diff/2001/webkit/tools/test_shell/test...
File webkit/tools/test_shell/test_shell_request_context.cc (right):

http://codereview.chromium.org/7036004/diff/2001/webkit/tools/test_shell/test...
webkit/tools/test_shell/test_shell_request_context.cc:102:
net::URLRequestJobFactory* job_factory = new net::URLRequestJobFactory;
Do we need to do something with this job_factory?  It looks like it's unused and
leaked.

[willchan no longer on Chromium, 2011-05-17 18:09:50]

http://codereview.chromium.org/7036004/diff/2001/webkit/tools/test_shell/test...
File webkit/tools/test_shell/test_shell_request_context.cc (right):

http://codereview.chromium.org/7036004/diff/2001/webkit/tools/test_shell/test...
webkit/tools/test_shell/test_shell_request_context.cc:102:
net::URLRequestJobFactory* job_factory = new net::URLRequestJobFactory;
On 2011/05/17 17:01:00, tony wrote:
> Do we need to do something with this job_factory?  It looks like it's unused
and
> leaked.

Oops, yeah. I've set it now.

[tony, 2011-05-17 18:13:21]

LGTM

[willchan no longer on Chromium, 2011-05-17 21:41:33]

+michaeln for webkit/fileapi and webkit/blob.

[michaeln, 2011-05-18 01:13:11]

thnx for the opportunity to take a look... i've got one stupid question

http://codereview.chromium.org/7036004/diff/3015/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_io_data.cc (right):

http://codereview.chromium.org/7036004/diff/3015/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_io_data.cc:444: set_protocol =
job_factory_->SetProtocolHandler(
I'm not familiar with the per-profile job_factory_ and the handlers installed in
it. Are they only utilized for requests associated with (one-of-the) profile's
request contexts?

http://codereview.chromium.org/7036004/diff/3015/webkit/blob/blob_url_request...
File webkit/blob/blob_url_request_job_factory.h (right):

http://codereview.chromium.org/7036004/diff/3015/webkit/blob/blob_url_request...
webkit/blob/blob_url_request_job_factory.h:31: base::MessageLoopProxy*
loop_proxy);
can u name this such that it indicates that it's the file_thread in some way

http://codereview.chromium.org/7036004/diff/3015/webkit/fileapi/file_system_u...
File webkit/fileapi/file_system_url_request_job_factory.h (right):

http://codereview.chromium.org/7036004/diff/3015/webkit/fileapi/file_system_u...
webkit/fileapi/file_system_url_request_job_factory.h:23: base::MessageLoopProxy*
loop_proxy);
can u name this such that it indicates that it's the file_thread in some way

[michaeln, 2011-05-18 01:25:09]

On 2011/05/18 01:13:11, michaeln wrote:
> thnx for the opportunity to take a look... i've got one stupid question

Make that two stupid questions... how do these defined at the per-profile level
interact with those defined globally... which get the first chance at handling
the request?

[willchan no longer on Chromium, 2011-05-18 16:17:01]

Per-profile takes precedence, just like how
URLRequest::RegisterProtocolFactory() used to work.

http://codereview.chromium.org/7036004/diff/3015/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_io_data.cc (right):

http://codereview.chromium.org/7036004/diff/3015/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_io_data.cc:444: set_protocol =
job_factory_->SetProtocolHandler(
On 2011/05/18 01:13:11, michaeln wrote:
> I'm not familiar with the per-profile job_factory_ and the handlers installed
in
> it. Are they only utilized for requests associated with (one-of-the) profile's
> request contexts?

Yes.

http://codereview.chromium.org/7036004/diff/3015/webkit/blob/blob_url_request...
File webkit/blob/blob_url_request_job_factory.h (right):

http://codereview.chromium.org/7036004/diff/3015/webkit/blob/blob_url_request...
webkit/blob/blob_url_request_job_factory.h:31: base::MessageLoopProxy*
loop_proxy);
On 2011/05/18 01:13:11, michaeln wrote:
> can u name this such that it indicates that it's the file_thread in some way

Done.

http://codereview.chromium.org/7036004/diff/3015/webkit/fileapi/file_system_u...
File webkit/fileapi/file_system_url_request_job_factory.h (right):

http://codereview.chromium.org/7036004/diff/3015/webkit/fileapi/file_system_u...
webkit/fileapi/file_system_url_request_job_factory.h:23: base::MessageLoopProxy*
loop_proxy);
On 2011/05/18 01:13:11, michaeln wrote:
> can u name this such that it indicates that it's the file_thread in some way

Done.

[michaeln, 2011-05-18 16:26:30]

LGTM (thnx for the explanation)

[commit-bot: I haz the power, 2011-05-18 16:30:34]

Can't process patch for file
webkit/fileapi/file_system_url_request_job_factory.cc.
A +