Issue 7035005: Install Git on Windows via depot tools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7035005: Install Git on Windows via depot tools. (Closed)

Created:
9 years, 7 months ago by cmp

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, nsylvain, M-A Ruel

CC:
chromium-reviews, Dirk Pranke

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Install Git on Windows via depot tools. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85568

Patch Set 6 : '' #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -1 line)			Patch
	M	bootstrap/win/win_tools.bat	View	1 2 3 4 5	2 chunks	+39 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

cmp

This is currently disabled behind a GIT_TOOLS_FORCE variable that must be set to 1 before ...

9 years, 7 months ago (2011-05-16 07:43:45 UTC) #2

M-A Ruel

lgtm http://codereview.chromium.org/7035005/diff/1/bootstrap/win/win_tools.bat File bootstrap/win/win_tools.bat (right): http://codereview.chromium.org/7035005/diff/1/bootstrap/win/win_tools.bat#newcode29 bootstrap/win/win_tools.bat:29: @rem call git --version 2>nul 1>nul Use ":: ...

9 years, 7 months ago (2011-05-16 19:26:02 UTC) #4

cmp

9 years, 7 months ago (2011-05-16 19:39:41 UTC) #5

http://codereview.chromium.org/7035005/diff/1/bootstrap/win/win_tools.bat
File bootstrap/win/win_tools.bat (right):

http://codereview.chromium.org/7035005/diff/1/bootstrap/win/win_tools.bat#new...
bootstrap/win/win_tools.bat:29: @rem call git --version 2>nul 1>nul
On 2011/05/16 19:26:02, Marc-Antoine Ruel wrote:
> Use ":: call git ..." instead of "@rem call git ...". It's safer with
> redirection.

Done.  I removed lines 29-30 and replaced with a :: comment explaining this is
where initialization will happen when we're ready to deploy.

Expand Messages | Collapse Messages

Issue 7035005: Install Git on Windows via depot tools. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Messages