Invoke grit_info as a python module.

Invoke grit_info as a python module.

This speeds up build/gyp_chromium by 7s on my system (for a total of 10s with the other grit_info changes I landed earlier).

BUG=82230
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87140

[Mark Mentovai, 2011-05-16 16:45:16]

Evidently Tony and I commented on http://codereview.chromium.org/7015061/
instead. I guess this is your replacement for that?

Some of those comments probably still apply to this.

[Nico, 2011-05-16 16:48:17]

On Mon, May 16, 2011 at 9:45 AM, <mark@chromium.org> wrote:

> Evidently Tony and I commented on http://codereview.chromium.org/7015061/


Nah, it was just you.


> instead. I guess this is your replacement for that?
>
> Some of those comments probably still apply to this.


Yes, I'll address the ones that do in a minute (or a different time unit;
let's see.)


>
>
> http://codereview.chromium.org/7035004/
>

[Mark Mentovai, 2011-05-16 16:52:38]

Nico Weber wrote:
> On Mon, May 16, 2011 at 9:45 AM, <mark@chromium.org> wrote:
>>
>> Evidently Tony and I commented on http://codereview.chromium.org/7015061/
>
> Nah, it was just you.

Allays IBF.

[Nico, 2011-05-28 00:04:51]

Alright, lets use this review for the final parts. ptal.

[Mark Mentovai, 2011-05-28 00:08:43]

LGTM

http://codereview.chromium.org/7035004/diff/8001/build/grit_action.gypi
File build/grit_action.gypi (right):

http://codereview.chromium.org/7035004/diff/8001/build/grit_action.gypi#newco...
build/grit_action.gypi:24: '<!@pymod_do_main(grit_info <@(grit_defines) ' +
We don’t usually + strings in .gyp files, we just let the lines grow.

[Nico, 2011-05-28 00:14:16]

http://codereview.chromium.org/7035004/diff/8001/build/grit_action.gypi
File build/grit_action.gypi (right):

http://codereview.chromium.org/7035004/diff/8001/build/grit_action.gypi#newco...
build/grit_action.gypi:24: '<!@pymod_do_main(grit_info <@(grit_defines) ' +
On 2011/05/28 00:08:43, Mark Mentovai wrote:
> We don’t usually + strings in .gyp files, we just let the lines grow.

Done.

[commit-bot: I haz the power, 2011-05-28 02:11:26]

Change committed as 87140

[dglazkov, 2011-06-02 16:18:45]

On 2011/05/28 02:11:26, commit-bot wrote:
> Change committed as 87140

Looks like this broke upstream WebKit build?
https://bugs.webkit.org/show_bug.cgi?id=61881

Nico, can you take a look?