Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 7034047: Exporting ScopedTempDir so it can be used by webkit layout tests. (Closed)

Created:
9 years, 7 months ago by gregsimon
Modified:
9 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Exporting ScopedTempDir so it can be used by webkit layout tests. Testing the LevelDB backend from the webkit unit tests requires it create a temporary file system. In order to clean this up (and on all platforms) we are going to make the scoped_temp_dir functionallity available to LayoutTestController. TEST=This is a thin wrapper on ScopedTempDir which is already covered by unit testing. This will be connected to LayoutTestController (a future patch in WebKit). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86148

Patch Set 1 #

Patch Set 2 : Fix for win build and chrome refactoring #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M webkit/support/webkit_support.h View 1 chunk +10 lines, -0 lines 0 comments Download
M webkit/support/webkit_support.cc View 1 2 chunks +21 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
gregsimon
9 years, 7 months ago (2011-05-19 05:26:36 UTC) #1
tony
LGTM
9 years, 7 months ago (2011-05-19 16:29:25 UTC) #2
commit-bot: I haz the power
Try job failure for 7034047-1 on win: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=32370
9 years, 7 months ago (2011-05-19 18:00:03 UTC) #3
commit-bot: I haz the power
Try job failure for 7034047-5001 on mac: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number=28116
9 years, 7 months ago (2011-05-20 18:12:57 UTC) #4
commit-bot: I haz the power
Change committed as 86148
9 years, 7 months ago (2011-05-20 21:38:55 UTC) #5
darin (slow to review)
9 years, 7 months ago (2011-05-23 16:29:56 UTC) #6
http://codereview.chromium.org/7034047/diff/5001/webkit/support/webkit_suppor...
File webkit/support/webkit_support.cc (right):

http://codereview.chromium.org/7034047/diff/5001/webkit/support/webkit_suppor...
webkit/support/webkit_support.cc:499: return
tempDirectory_.path().MaybeAsASCII();
this probably isn't a big deal for developers, but this looks like it would not
work well if the temporary directory contains non-ASCII chars (can happen on
Windows).

we normally pass file paths to webkit using WebString and
webkit_glue::FilePathToWebString.

Powered by Google App Engine
This is Rietveld 408576698