Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 7034035: Make DHCP WPAD on by default. (Closed)

Created:
9 years, 7 months ago by Jói
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., eroman
Visibility:
Public.

Description

Make DHCP WPAD on by default. BUG=18575 TEST=Run Chrome on Windows without any flags. Enable auto-detect in proxy configuration. Net log should show attempts to auto-detect via DHCP. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86422

Patch Set 1 #

Patch Set 2 : Fix comment on set_enabled() #

Patch Set 3 : Merge to head. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M chrome/browser/net/connection_tester.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/proxy_service_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M net/proxy/dhcp_proxy_script_fetcher_factory.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/dhcp_proxy_script_fetcher_factory.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/proxy/dhcp_proxy_script_fetcher_factory_unittest.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jói
Hi Wan-Teh, As discussed. I will only submit this once we we also have metrics ...
9 years, 7 months ago (2011-05-18 20:16:46 UTC) #1
eroman%chromium.org
LGTM
9 years, 7 months ago (2011-05-18 20:25:22 UTC) #2
wtc
LGTM.
9 years, 7 months ago (2011-05-18 23:43:56 UTC) #3
Jói
9 years, 7 months ago (2011-05-24 14:13:09 UTC) #4
Eric, looks like your LGTM didn't get processed because your email address was
wonky (eroman%chromium.org), so I am committing with --bypass-hooks (the change
needs LGTM from someone in chrome/browser/net/OWNERS, you are there and have
LGTMed but the script won't buy it).

Cheers,
Jói

Powered by Google App Engine
This is Rietveld 408576698