Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 7033062: Replaced ptrdiff_t with std::ptrdiff_t in all files to enable build with gcc-4.6.0. (Closed)

Created:
9 years, 6 months ago by asharif1
Modified:
8 years, 8 months ago
CC:
chromium-reviews, bjanakiraman
Visibility:
Public.

Description

Replaced ptrdiff_t with std::ptrdiff_t in all files.

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M third_party/tcmalloc/chromium/src/base/stl_allocator.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/tcmalloc/chromium/src/base/vdso_support.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/tcmalloc/chromium/src/google/malloc_hook.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/tcmalloc/chromium/src/google/malloc_hook_c.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/tcmalloc/chromium/src/heap-checker.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/tcmalloc/chromium/src/heap-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/tcmalloc/chromium/src/malloc_hook.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/tcmalloc/chromium/src/malloc_hook-inl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/tcmalloc/chromium/src/memory_region_map.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/tcmalloc/chromium/src/memory_region_map.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/tcmalloc/chromium/src/symbolize.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/tcmalloc/chromium/src/system-alloc.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/tcmalloc/chromium/src/windows/port.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
asharif1
Please review. Note: I am not a committer. I deleted the earlier CL because it ...
9 years, 6 months ago (2011-06-06 23:24:37 UTC) #1
asharif1
Ping. Who else can review/submit this? On 2011/06/06 23:24:37, asharif1 wrote: > Please review. Note: ...
9 years, 6 months ago (2011-06-08 00:21:54 UTC) #2
Alexander Potapenko
I've opened http://codereview.chromium.org/7046043 and posted the tryjobs. Will submit if/once they pass. Please consider using ...
9 years, 6 months ago (2011-06-08 09:52:15 UTC) #3
Alexander Potapenko
Compilation passed on the bots. LGTM, awaiting the tree to open.
9 years, 6 months ago (2011-06-08 13:12:51 UTC) #4
Alexander Potapenko
9 years, 6 months ago (2011-06-08 15:10:57 UTC) #5
On 2011/06/08 13:12:51, Alexander Potapenko wrote:
> Compilation passed on the bots.
> LGTM, awaiting the tree to open.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88328

Powered by Google App Engine
This is Rietveld 408576698