chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm - Issue 7033048: Multi-tab: Adding new Notification when tab selection changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

Issue 7033048: Multi-tab: Adding new Notification when tab selection changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing existing unit tests, adding new unit test for multiple selection. Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

diff --git a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

index 9b2ff8d89e85ec4d3be7f2645504f19fd0c68ae2..cbb15c6373b774efb28839958d6247318cc3584f 100644

--- a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

+++ b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

@@ -1215,7 +1215,7 @@ class NotificationBridge : public NotificationObserver {

// Take closing tabs into account.

NSInteger activeIndex = [self indexFromModelIndex:modelIndex];

- if (oldContents && oldContents != newContents) {

+ if (oldContents) {

int oldModelIndex =

browser_->GetIndexOfController(&(oldContents->controller()));

if (oldModelIndex != -1) { // When closing a tab, the old tab may be gone.