[Sync] Speed up sync node browser/search in about:sync

chrome/browser/sync/engine/syncer_util.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/engine/syncer_util.h"
 
 #include <algorithm>
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 72 matching lines @@
   syncable::Id old_id = entry->Get(ID);
   if (!entry->Put(ID, new_id)) {
     Entry old_entry(trans, GET_BY_ID, new_id);
     CHECK(old_entry.good());
     LOG(FATAL) << "Attempt to change ID to " << new_id
                << " conflicts with existing entry.\n\n"
                << *entry << "\n\n" << old_entry;
   }
   if (entry->Get(IS_DIR)) {
     // Get all child entries of the old id.
-    trans->directory()->GetChildHandles(trans, old_id, children);
+    trans->directory()->GetChildHandlesById(trans, old_id, children);
     Directory::ChildHandles::iterator i = children->begin();
     while (i != children->end()) {
       MutableEntry child_entry(trans, GET_BY_HANDLE, *i++);
       CHECK(child_entry.good());
       // Use the unchecked setter here to avoid touching the child's NEXT_ID
       // and PREV_ID fields (which Put(PARENT_ID) would normally do to
       // maintain linked-list invariants).  In this case, NEXT_ID and PREV_ID
       // among the children will be valid after the loop, since we update all
       // the children at once.
       child_entry.PutParentIdPropertyOnly(new_id);
@@ skipping 168 matching lines @@
     }
     if (entry->Get(PARENT_ID) != new_parent) {
       if (!entry->Get(IS_DEL) && !IsLegalNewParent(trans, id, new_parent)) {
         VLOG(1) << "Not updating item " << id
                 << ", illegal new parent (would cause loop).";
         return CONFLICT;
       }
     }
   } else if (entry->Get(IS_DIR)) {
     Directory::ChildHandles handles;
-    trans->directory()->GetChildHandles(trans, id, &handles);
+    trans->directory()->GetChildHandlesById(trans, id, &handles);
     if (!handles.empty()) {
       // If we have still-existing children, then we need to deal with
       // them before we can process this change.
       VLOG(1) << "Not deleting directory; it's not empty " << *entry;
       return CONFLICT;
     }
   }
 
   // We intercept updates to the Nigori node, update the Cryptographer and
   // encrypt any unsynced changes here because there is no Nigori
@@ skipping 533 matching lines @@
   if (update.version() < target->Get(SERVER_VERSION)) {
     LOG(WARNING) << "Update older than current server version for "
                  << *target << " Update:"
                  << SyncerProtoUtil::SyncEntityDebugString(update);
     return VERIFY_SUCCESS;  // Expected in new sync protocol.
   }
   return VERIFY_UNDECIDED;
 }
 
 }  // namespace browser_sync