[Sync] Speed up sync node browser/search in about:sync

chrome/browser/sync/engine/syncer_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Syncer unit tests. Unfortunately a lot of these tests
 // are outdated and need to be reworked and updated.
 
 #include <algorithm>
 #include <limits>
 #include <list>
@@ skipping 180 matching lines @@
         syncdb_.manager(), this, listeners));
     context_->set_account_name(syncdb_.name());
     ASSERT_FALSE(context_->resolver());
     syncer_ = new Syncer();
     session_.reset(MakeSession());
 
     ScopedDirLookup dir(syncdb_.manager(), syncdb_.name());
     CHECK(dir.good());
     ReadTransaction trans(dir, __FILE__, __LINE__);
     syncable::Directory::ChildHandles children;
-    dir->GetChildHandles(&trans, trans.root_id(), &children);
+    dir->GetChildHandlesById(&trans, trans.root_id(), &children);
     ASSERT_TRUE(0 == children.size());
     saw_syncer_event_ = false;
     root_id_ = TestIdFactory::root();
     parent_id_ = ids_.MakeServer("parent id");
     child_id_ = ids_.MakeServer("child id");
   }
 
   virtual void TearDown() {
     mock_server_.reset();
     delete syncer_;
@@ skipping 1669 matching lines @@
     child.Put(syncable::ID, child_id_);
     child.Put(syncable::BASE_VERSION, 10);
     WriteTestDataToEntry(&wtrans, &child);
   }
   mock_server_->AddUpdateBookmark(child_id_, parent_id_, "Pete2.htm", 11, 10);
   mock_server_->set_conflict_all_commits(true);
   LoopSyncShare();
   syncable::Directory::ChildHandles children;
   {
     ReadTransaction trans(dir, __FILE__, __LINE__);
-    dir->GetChildHandles(&trans, parent_id_, &children);
+    dir->GetChildHandlesById(&trans, parent_id_, &children);
     // We expect the conflict resolver to preserve the local entry.
     Entry child(&trans, syncable::GET_BY_ID, child_id_);
     ASSERT_TRUE(child.good());
     EXPECT_TRUE(child.Get(syncable::IS_UNSYNCED));
     EXPECT_FALSE(child.Get(syncable::IS_UNAPPLIED_UPDATE));
     EXPECT_TRUE(child.Get(SPECIFICS).HasExtension(sync_pb::bookmark));
     EXPECT_EQ("Pete.htm", child.Get(NON_UNIQUE_NAME));
     VerifyTestBookmarkDataInEntry(&child);
   }
 
@@ skipping 73 matching lines @@
   }
   mock_server_->AddUpdateDirectory(parent_id, root_id_, "Folder", 10, 10);
   mock_server_->AddUpdateBookmark(child_id, parent_id, "test.htm", 10, 10);
   mock_server_->set_conflict_all_commits(true);
   SyncShareAsDelegate();
   SyncShareAsDelegate();
   SyncShareAsDelegate();
   {
     ReadTransaction trans(dir, __FILE__, __LINE__);
     Directory::ChildHandles children;
-    dir->GetChildHandles(&trans, root_id_, &children);
+    dir->GetChildHandlesById(&trans, root_id_, &children);
     EXPECT_TRUE(1 == children.size());
-    dir->GetChildHandles(&trans, parent_id, &children);
+    dir->GetChildHandlesById(&trans, parent_id, &children);
     EXPECT_TRUE(1 == children.size());
     Directory::UnappliedUpdateMetaHandles unapplied;
     dir->GetUnappliedUpdateMetaHandles(&trans, &unapplied);
     EXPECT_TRUE(0 == unapplied.size());
     syncable::Directory::UnsyncedMetaHandles unsynced;
     dir->GetUnsyncedMetaHandles(&trans, &unsynced);
     EXPECT_TRUE(0 == unsynced.size());
     saw_syncer_event_ = false;
   }
 }
@@ skipping 1113 matching lines @@
     ScopedDirLookup dir(syncdb_.manager(), syncdb_.name());
     ASSERT_TRUE(dir.good());
 
     const syncable::Id susan_id = TestIdFactory::FromNumber(susan_int_id_);
     ASSERT_GT(countdown_till_delete_, 0);
     if (0 != --countdown_till_delete_)
     return;
   WriteTransaction trans(dir, UNITTEST, __FILE__, __LINE__);
     MutableEntry susan(&trans, GET_BY_ID, susan_id);
   Directory::ChildHandles children;
-  dir->GetChildHandles(&trans, susan.Get(ID), &children);
+  dir->GetChildHandlesById(&trans, susan.Get(ID), &children);
   ASSERT_TRUE(0 == children.size());
   susan.Put(IS_DEL, true);
   susan.Put(IS_UNSYNCED, true);
 }
 
  protected:
   int countdown_till_delete_;
 };
 
 TEST_F(SusanDeletingTest,
@@ skipping 1149 matching lines @@
     ASSERT_TRUE(ids_.FromNumber(4) == tag2.Get(ID));
     EXPECT_FALSE(tag2.Get(IS_DEL));
     EXPECT_FALSE(tag2.Get(IS_UNAPPLIED_UPDATE));
     EXPECT_FALSE(tag2.Get(IS_UNSYNCED));
     EXPECT_EQ("Four", tag2.Get(NON_UNIQUE_NAME));
     EXPECT_EQ(11, tag2.Get(BASE_VERSION));
     EXPECT_EQ("tag2", tag2.Get(UNIQUE_CLIENT_TAG));
     tag2_metahandle = tag2.Get(META_HANDLE);
 
     syncable::Directory::ChildHandles children;
-    dir->GetChildHandles(&trans, trans.root_id(), &children);
+    dir->GetChildHandlesById(&trans, trans.root_id(), &children);
     ASSERT_EQ(2U, children.size());
   }
 
   mock_server_->AddUpdateBookmark(2, 0, "Two", 12, 120);
   mock_server_->SetLastUpdateClientTag("tag1");
   mock_server_->AddUpdateBookmark(3, 0, "Three", 13, 130);
   mock_server_->SetLastUpdateClientTag("tag2");
   SyncShareAsDelegate();
 
   {
@@ skipping 19 matching lines @@
         << "ID 3 should be kept, since it was less than ID 4.";
     EXPECT_FALSE(tag2.Get(IS_DEL));
     EXPECT_FALSE(tag2.Get(IS_UNAPPLIED_UPDATE));
     EXPECT_FALSE(tag2.Get(IS_UNSYNCED));
     EXPECT_EQ("Three", tag2.Get(NON_UNIQUE_NAME));
     EXPECT_EQ(13, tag2.Get(BASE_VERSION));
     EXPECT_EQ("tag2", tag2.Get(UNIQUE_CLIENT_TAG));
     EXPECT_EQ(tag2_metahandle, tag2.Get(META_HANDLE));
 
     syncable::Directory::ChildHandles children;
-    dir->GetChildHandles(&trans, trans.root_id(), &children);
+    dir->GetChildHandlesById(&trans, trans.root_id(), &children);
     ASSERT_EQ(2U, children.size());
   }
 }
 
 TEST_F(SyncerTest, ClientTagClashWithinBatchOfUpdates) {
   ScopedDirLookup dir(syncdb_.manager(), syncdb_.name());
   EXPECT_TRUE(dir.good());
 
   // This test is written assuming that ID comparison
   // will work out in a particular way.
@@ skipping 61 matching lines @@
     EXPECT_TRUE(tag_c.Get(ID).ServerKnows());
     EXPECT_EQ(ids_.FromNumber(201), tag_c.Get(ID));
     EXPECT_FALSE(tag_c.Get(IS_DEL));
     EXPECT_FALSE(tag_c.Get(IS_UNAPPLIED_UPDATE));
     EXPECT_FALSE(tag_c.Get(IS_UNSYNCED));
     EXPECT_EQ("Four C", tag_c.Get(NON_UNIQUE_NAME));
     EXPECT_EQ(21, tag_c.Get(BASE_VERSION));
     EXPECT_EQ("tag c", tag_c.Get(UNIQUE_CLIENT_TAG));
 
     syncable::Directory::ChildHandles children;
-    dir->GetChildHandles(&trans, trans.root_id(), &children);
+    dir->GetChildHandlesById(&trans, trans.root_id(), &children);
     ASSERT_EQ(3U, children.size());
   }
 }
 
 TEST_F(SyncerTest, UniqueServerTagUpdates) {
   ScopedDirLookup dir(syncdb_.manager(), syncdb_.name());
   EXPECT_TRUE(dir.good());
   // As a hurdle, introduce an item whose name is the same as the tag value
   // we'll use later.
   int64 hurdle_handle = CreateUnsyncedDirectory("bob", "id_bob");
@@ skipping 753 matching lines @@
   Add(low_id_);
   Add(high_id_);
   SyncShareAsDelegate();
   ExpectLocalOrderIsByServerId();
 }
 
 const SyncerTest::CommitOrderingTest
 SyncerTest::CommitOrderingTest::LAST_COMMIT_ITEM = {-1, TestIdFactory::root()};
 
 }  // namespace browser_sync