Linux: split ProxyConfigServiceLinux::SettingGetter::Setting into several enums.

Linux: split ProxyConfigServiceLinux::SettingGetter::Setting into several enums, one for each type of setting. This provides additional type safety.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86149

[vandebo (ex-Chrome), 2011-05-20 20:05:48]

LGTM w/ nit.

http://codereview.chromium.org/7033040/diff/1/net/proxy/proxy_config_service_...
File net/proxy/proxy_config_service_linux.cc (right):

http://codereview.chromium.org/7033040/diff/1/net/proxy/proxy_config_service_...
net/proxy/proxy_config_service_linux.cc:317: return false;  // placate compiler
nit: Comments should be sentences... "Placate compiler."

[Mike Mammarella, 2011-05-20 20:42:36]

http://codereview.chromium.org/7033040/diff/1/net/proxy/proxy_config_service_...
File net/proxy/proxy_config_service_linux.cc (right):

http://codereview.chromium.org/7033040/diff/1/net/proxy/proxy_config_service_...
net/proxy/proxy_config_service_linux.cc:317: return false;  // placate compiler
On 2011/05/20 20:05:49, vandebo wrote:
> nit: Comments should be sentences... "Placate compiler."

Done.

[vandebo (ex-Chrome), 2011-05-20 20:58:05]

LGTM

[commit-bot: I haz the power, 2011-05-20 21:46:49]

Change committed as 86149