Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 7033039: Add integration tests for instant.py. (Closed)

Created:
9 years, 7 months ago by dyu1
Modified:
9 years, 7 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, John Grabowski, anantha, Nirnimesh, dyu1, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add integration tests for instant.py. - testPreFetchInstantURLNotInHistory - testPreFetchInstantURLGeneratesNoPopups - testPreFetchInstantURLSetsNoCookies BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86156

Patch Set 1 #

Total comments: 13

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M chrome/test/functional/instant.py View 1 1 chunk +26 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
dyu1
9 years, 7 months ago (2011-05-20 00:47:49 UTC) #1
Nirnimesh
Love these tests. Just what I meant when I talked about more integrated tests. http://codereview.chromium.org/7033039/diff/1/chrome/test/functional/instant.py ...
9 years, 7 months ago (2011-05-20 02:02:03 UTC) #2
dyu1
http://codereview.chromium.org/7033039/diff/1/chrome/test/functional/instant.py File chrome/test/functional/instant.py (right): http://codereview.chromium.org/7033039/diff/1/chrome/test/functional/instant.py#newcode196 chrome/test/functional/instant.py:196: """Test that pre-fetched URL not saved in History.""" On ...
9 years, 7 months ago (2011-05-20 04:19:06 UTC) #3
Nirnimesh
9 years, 7 months ago (2011-05-20 04:46:50 UTC) #4
LGTM with minor suggestions.

http://codereview.chromium.org/7033039/diff/5001/chrome/test/functional/insta...
File chrome/test/functional/instant.py (right):

http://codereview.chromium.org/7033039/diff/5001/chrome/test/functional/insta...
chrome/test/functional/instant.py:204: os.path.join('pyauto_private',
'popup_blocker',
os.path.join is not needed.

You can do:

file_Url = self.GetHttpURLForDataPath('pyauto_private', 'popup_blocker',
'PopupTest1.html')

http://codereview.chromium.org/7033039/diff/5001/chrome/test/functional/insta...
chrome/test/functional/instant.py:215: http_url = 'http://www.google.com'
You could use cookie1.html from the data dir. It'll make this test faster.

Powered by Google App Engine
This is Rietveld 408576698