Add integration tests for instant.py.

Add integration tests for instant.py.

 - testPreFetchInstantURLNotInHistory
 - testPreFetchInstantURLGeneratesNoPopups
 - testPreFetchInstantURLSetsNoCookies

BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86156

[Nirnimesh, 2011-05-20 02:02:03]

Love these tests. Just what I meant when I talked about more integrated tests.

http://codereview.chromium.org/7033039/diff/1/chrome/test/functional/instant.py
File chrome/test/functional/instant.py (right):

http://codereview.chromium.org/7033039/diff/1/chrome/test/functional/instant....
chrome/test/functional/instant.py:196: """Test that pre-fetched URL not saved in
History."""
s/not/are not/

http://codereview.chromium.org/7033039/diff/1/chrome/test/functional/instant....
chrome/test/functional/instant.py:198: raw_input()
remove

http://codereview.chromium.org/7033039/diff/1/chrome/test/functional/instant....
chrome/test/functional/instant.py:200: print history
remove

http://codereview.chromium.org/7033039/diff/1/chrome/test/functional/instant....
chrome/test/functional/instant.py:204: """Test that pre-fetched URL does not
generate pop-ups."""
s/pop-ups/popups/

http://codereview.chromium.org/7033039/diff/1/chrome/test/functional/instant....
chrome/test/functional/instant.py:208:
self.SetOmniboxText('http://www.popuptest.com/popuptest1.html')
WaitForOmniboxQueryDone() after this line

http://codereview.chromium.org/7033039/diff/1/chrome/test/functional/instant....
chrome/test/functional/instant.py:208:
self.SetOmniboxText('http://www.popuptest.com/popuptest1.html')
can we use a local http url here?

http://codereview.chromium.org/7033039/diff/1/chrome/test/functional/instant....
chrome/test/functional/instant.py:215: self.SetOmniboxText(http_url)
WaitForOmniboxQueryDone() after this line

[dyu1, 2011-05-20 04:19:06]

http://codereview.chromium.org/7033039/diff/1/chrome/test/functional/instant.py
File chrome/test/functional/instant.py (right):

http://codereview.chromium.org/7033039/diff/1/chrome/test/functional/instant....
chrome/test/functional/instant.py:196: """Test that pre-fetched URL not saved in
History."""
On 2011/05/20 02:02:03, Nirnimesh wrote:
> s/not/are not/

Done.

http://codereview.chromium.org/7033039/diff/1/chrome/test/functional/instant....
chrome/test/functional/instant.py:198: raw_input()
On 2011/05/20 02:02:03, Nirnimesh wrote:
> remove

Done.

http://codereview.chromium.org/7033039/diff/1/chrome/test/functional/instant....
chrome/test/functional/instant.py:200: print history
On 2011/05/20 02:02:03, Nirnimesh wrote:
> remove

Done.

http://codereview.chromium.org/7033039/diff/1/chrome/test/functional/instant....
chrome/test/functional/instant.py:204: """Test that pre-fetched URL does not
generate pop-ups."""
On 2011/05/20 02:02:03, Nirnimesh wrote:
> s/pop-ups/popups/

Done.

http://codereview.chromium.org/7033039/diff/1/chrome/test/functional/instant....
chrome/test/functional/instant.py:208:
self.SetOmniboxText('http://www.popuptest.com/popuptest1.html')
On 2011/05/20 02:02:03, Nirnimesh wrote:
> can we use a local http url here?

Done.

http://codereview.chromium.org/7033039/diff/1/chrome/test/functional/instant....
chrome/test/functional/instant.py:215: self.SetOmniboxText(http_url)
On 2011/05/20 02:02:03, Nirnimesh wrote:
> WaitForOmniboxQueryDone() after this line

Done.

[Nirnimesh, 2011-05-20 04:46:50]

LGTM with minor suggestions.

http://codereview.chromium.org/7033039/diff/5001/chrome/test/functional/insta...
File chrome/test/functional/instant.py (right):

http://codereview.chromium.org/7033039/diff/5001/chrome/test/functional/insta...
chrome/test/functional/instant.py:204: os.path.join('pyauto_private',
'popup_blocker',
os.path.join is not needed.

You can do:

file_Url = self.GetHttpURLForDataPath('pyauto_private', 'popup_blocker',
'PopupTest1.html')

http://codereview.chromium.org/7033039/diff/5001/chrome/test/functional/insta...
chrome/test/functional/instant.py:215: http_url = 'http://www.google.com'
You could use cookie1.html from the data dir. It'll make this test faster.