Issue 7033038: Make 'ignoreCase' works in collator.

Issue 7033038: Make 'ignoreCase' works in collator. (Closed)

Created:
9 years, 7 months ago by jungshik at Google

Modified:
9 years, 6 months ago

Reviewers:
Nebojša Ćirić

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Make 'ignoreCase' works in collator. BUG=28604 TEST=http://www.i18nl10n.com/chrome/coll.html

Patch Set 3 : '' #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, --1 lines)			Patch
	M	src/extensions/experimental/collator.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
	MM	src/extensions/experimental/collator.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nebojša Ćirić

http://codereview.chromium.org/7033038/diff/1/src/extensions/experimental/collator.cc File src/extensions/experimental/collator.cc (right): http://codereview.chromium.org/7033038/diff/1/src/extensions/experimental/collator.cc#newcode156 src/extensions/experimental/collator.cc:156: // Need to explicitly set the level to secondary ...

9 years, 7 months ago (2011-05-20 16:46:57 UTC) #2

jungshik at Google

9 years, 7 months ago (2011-05-23 17:23:12 UTC) #3

On 2011/05/20 16:46:57, Nebojša Ćirić wrote:
>
http://codereview.chromium.org/7033038/diff/1/src/extensions/experimental/col...
> File src/extensions/experimental/collator.cc (right):
> 
>
http://codereview.chromium.org/7033038/diff/1/src/extensions/experimental/col...
> src/extensions/experimental/collator.cc:156: // Need to explicitly set the
level
> to secondary to get case ignored.
> Nit: Needs to...

Added 'we'  :-)

> 
>
http://codereview.chromium.org/7033038/diff/1/src/extensions/experimental/i18...
> File src/extensions/experimental/i18n.js (right):
> 
>
http://codereview.chromium.org/7033038/diff/1/src/extensions/experimental/i18...
> src/extensions/experimental/i18n.js:128: return collator;
> Do you want to add derive method here, and return actual .options?
> Collation is one of the classes that could actually benefit from having derive
> method.
> Separate CL is ok.

Yup, I made this CL trivial on purpose. I'll make a separate CL for that.

Expand Messages | Collapse Messages