Print Preview: Fixing print header alignment, "Preview loading..." spacing and animation

Print Preview: Fixing print header alignment, "Preview loading..." spacing and animation

BUG=82965, 82969, 83411
TEST=See bugs description.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86142

[Lei Zhang, 2011-05-19 23:13:51]

Did you forget the .grd change for bug 82965?

[Lei Zhang, 2011-05-19 23:14:56]

For the CSS changes, can you show it to Marcin and make sure he's ok with it?

[dpapad, 2011-05-19 23:22:50]

On 2011/05/19 23:14:56, Lei Zhang wrote:
> For the CSS changes, can you show it to Marcin and make sure he's ok with it?

There is no .grd change. The space between "loading" and "..." occurs because of
the default margin of <span>, this is handled in the css change. Maybe there is
a better way to handle this. I was going to show to Marcin before marking the
bug as fixed.

[Lei Zhang, 2011-05-19 23:27:20]

On 2011/05/19 23:22:50, dpapad wrote:
> On 2011/05/19 23:14:56, Lei Zhang wrote:
> > For the CSS changes, can you show it to Marcin and make sure he's ok with
it?
> 
> There is no .grd change. The space between "loading" and "..." occurs because
of
> the default margin of <span>, this is handled in the css change. Maybe there
is
> a better way to handle this. I was going to show to Marcin before marking the
> bug as fixed.

Is there a reason you put the '...' in the html as <span>.</span> x 3 ? 

Why not put it in the .grd file. There's several other strings in there that are
"Loading...". I don't know if the current string + <span>s is going to come out
right for bidi.

[dpapad, 2011-05-20 15:32:01]

On 2011/05/19 23:27:20, Lei Zhang wrote:
> On 2011/05/19 23:22:50, dpapad wrote:
> > On 2011/05/19 23:14:56, Lei Zhang wrote:
> > > For the CSS changes, can you show it to Marcin and make sure he's ok with
> it?
> > 
> > There is no .grd change. The space between "loading" and "..." occurs
because
> of
> > the default margin of <span>, this is handled in the css change. Maybe there
> is
> > a better way to handle this. I was going to show to Marcin before marking
the
> > bug as fixed.
> 
> Is there a reason you put the '...' in the html as <span>.</span> x 3 ? 
> 
> Why not put it in the .grd file. There's several other strings in there that
are
> "Loading...". I don't know if the current string + <span>s is going to come
out
> right for bidi.

As per our discussion the dots are in the html file in successive spans in order
for the animation to work. I checked it in rtl mode and it looks ok.

[Lei Zhang, 2011-05-20 16:57:55]

On 2011/05/20 15:32:01, dpapad wrote:
> On 2011/05/19 23:27:20, Lei Zhang wrote:
> > On 2011/05/19 23:22:50, dpapad wrote:
> > > On 2011/05/19 23:14:56, Lei Zhang wrote:
> > > > For the CSS changes, can you show it to Marcin and make sure he's ok
with
> > it?
> > > 
> > > There is no .grd change. The space between "loading" and "..." occurs
> because
> > of
> > > the default margin of <span>, this is handled in the css change. Maybe
there
> > is
> > > a better way to handle this. I was going to show to Marcin before marking
> the
> > > bug as fixed.
> > 
> > Is there a reason you put the '...' in the html as <span>.</span> x 3 ? 
> > 
> > Why not put it in the .grd file. There's several other strings in there that
> are
> > "Loading...". I don't know if the current string + <span>s is going to come
> out
> > right for bidi.
> 
> As per our discussion the dots are in the html file in successive spans in
order
> for the animation to work. I checked it in rtl mode and it looks ok.

Ok, LGTM

[dpapad, 2011-05-20 20:39:40]

Just squeezed one more minor bug fix in this CL.

[Lei Zhang, 2011-05-20 20:50:00]

On 2011/05/20 20:39:40, dpapad wrote:
> Just squeezed one more minor bug fix in this CL.

Ok, still LGTM.