Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 7033037: Print Preview: Fixing print header alignment, "Preview loading..." spacing and animation (Closed)

Created:
9 years, 7 months ago by dpapad
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Print Preview: Fixing print header alignment, "Preview loading..." spacing and animation BUG=82965, 82969, 83411 TEST=See bugs description. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86142

Patch Set 1 #

Patch Set 2 : Making print preview area not selectable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/browser/resources/print_preview.css View 1 4 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/resources/print_preview.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
dpapad
9 years, 7 months ago (2011-05-19 23:03:33 UTC) #1
Lei Zhang
Did you forget the .grd change for bug 82965?
9 years, 7 months ago (2011-05-19 23:13:51 UTC) #2
Lei Zhang
For the CSS changes, can you show it to Marcin and make sure he's ok ...
9 years, 7 months ago (2011-05-19 23:14:56 UTC) #3
dpapad
On 2011/05/19 23:14:56, Lei Zhang wrote: > For the CSS changes, can you show it ...
9 years, 7 months ago (2011-05-19 23:22:50 UTC) #4
Lei Zhang
On 2011/05/19 23:22:50, dpapad wrote: > On 2011/05/19 23:14:56, Lei Zhang wrote: > > For ...
9 years, 7 months ago (2011-05-19 23:27:20 UTC) #5
dpapad
On 2011/05/19 23:27:20, Lei Zhang wrote: > On 2011/05/19 23:22:50, dpapad wrote: > > On ...
9 years, 7 months ago (2011-05-20 15:32:01 UTC) #6
Lei Zhang
On 2011/05/20 15:32:01, dpapad wrote: > On 2011/05/19 23:27:20, Lei Zhang wrote: > > On ...
9 years, 7 months ago (2011-05-20 16:57:55 UTC) #7
dpapad
Just squeezed one more minor bug fix in this CL.
9 years, 7 months ago (2011-05-20 20:39:40 UTC) #8
Lei Zhang
9 years, 7 months ago (2011-05-20 20:50:00 UTC) #9
On 2011/05/20 20:39:40, dpapad wrote:
> Just squeezed one more minor bug fix in this CL.

Ok, still LGTM.

Powered by Google App Engine
This is Rietveld 408576698