Issue 7033035: Change HMAC::Sign() to take base::StringPiece instead of string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7033035: Change HMAC::Sign() to take base::StringPiece instead of string. (Closed)

Created:
9 years, 7 months ago by Alpha Left Google

Modified:
9 years, 6 months ago

Reviewers:
wtc

CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Change HMAC::Sign() to take base::StringPiece instead of string. Do this to avoid memory copying when signning data in char*. base::StringPiece nicely handles both cases. BUG=None TEST=crypto_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88049

Patch Set 1 #

Patch Set 2 : done #

Patch Set 3 : fix it #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
M	crypto/hmac.h	View	1 2	2 chunks	+2 lines, -2 lines	1 comment	Download
M	crypto/hmac_mac.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	crypto/hmac_nss.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	crypto/hmac_openssl.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	crypto/hmac_win.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

wtc

9 years, 6 months ago (2011-06-02 19:56:48 UTC) #2

LGTM.

I assume that there is cheap, automatic conversion from
std::string to base::StringPiece?

I suggest a change below to finish the job.

http://codereview.chromium.org/7033035/diff/4001/crypto/hmac.h
File crypto/hmac.h (right):

http://codereview.chromium.org/7033035/diff/4001/crypto/hmac.h#newcode46
crypto/hmac.h:46: bool Init(const std::string& key) {
Can you also change 'key' to a StringPiece, and remove
the <string> header inclusion on line 12 above?

Expand Messages | Collapse Messages